From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
raghavendra.kt@linux.vnet.ibm.com, edumazet@google.com,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, jiri@resnulli.us, hannes@stressinduktion.org,
tom@herbertland.com, azhou@nicira.com, ebiederm@xmission.com,
ipm@chirality.org.uk, nicolas.dichtel@6wind.com,
serge.hallyn@canonical.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, anton@au1.ibm.com,
nacc@linux.vnet.ibm.com, srikar@linux.vnet.ibm.com
Subject: Re: [PATCH RFC V2 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once
Date: Fri, 28 Aug 2015 14:09:43 -0700 [thread overview]
Message-ID: <1440796183.11525.153.camel@perches.com> (raw)
In-Reply-To: <1440795336.8932.46.camel@edumazet-glaptop2.roam.corp.google.com>
On Fri, 2015-08-28 at 13:55 -0700, Eric Dumazet wrote:
> On Fri, 2015-08-28 at 13:53 -0700, Joe Perches wrote:
> > On Fri, 2015-08-28 at 13:33 -0700, Eric Dumazet wrote:
> > > We do not bother for small struct.
> > >
> > > Here, the array is big enough that David prefers having an explicit
> > > memset() so that it clearly shows that author of this code was aware of
> > > this.
> >
> > It's 288 bytes on stack, maybe a kzalloc would be clearer too.
>
> Could you read patch history and check why this has been rejected ?
I don't see a rejection, just that the initial
submission didn't check the allocation or add
an allocation buffer via kcalloc/kzalloc to the
inet6_fill_ifla6_attrs caller and change the
snmp6_fill_stats arguments.
It could also eliminate the put_unaligned calls.
https://lkml.org/lkml/2015/8/25/114
Was there some other thread?
next prev parent reply other threads:[~2015-08-28 21:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 17:37 [PATCH RFC V2 0/2] Optimize the snmp stat aggregation for large cpus Raghavendra K T
2015-08-26 17:37 ` [PATCH RFC V2 1/2] net: Introduce helper functions to get the per cpu data Raghavendra K T
2015-08-26 17:37 ` [PATCH RFC V2 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once Raghavendra K T
2015-08-27 18:38 ` David Miller
2015-08-28 6:39 ` Raghavendra K T
2015-08-28 18:24 ` David Miller
2015-08-28 19:20 ` Joe Perches
2015-08-28 20:33 ` Eric Dumazet
2015-08-28 20:53 ` Joe Perches
2015-08-28 20:55 ` Eric Dumazet
2015-08-28 21:09 ` Joe Perches [this message]
2015-08-28 21:14 ` Eric Dumazet
2015-08-28 21:26 ` Joe Perches
2015-08-28 22:29 ` Eric Dumazet
2015-08-28 23:12 ` Joe Perches
2015-08-29 0:06 ` Eric Dumazet
2015-08-29 0:35 ` Joe Perches
2015-08-29 0:59 ` Eric Dumazet
2015-08-29 2:57 ` Raghavendra K T
2015-08-29 3:26 ` Eric Dumazet
2015-08-29 7:52 ` Raghavendra K T
2015-08-29 5:11 ` David Miller
2015-08-29 7:53 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440796183.11525.153.camel@perches.com \
--to=joe@perches.com \
--cc=anton@au1.ibm.com \
--cc=azhou@nicira.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=ipm@chirality.org.uk \
--cc=jiri@resnulli.us \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=serge.hallyn@canonical.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=tom@herbertland.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.