From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi_nand_spl: Be smarter about where to look for backup u-boot.bin
Date: Tue, 01 Sep 2015 08:05:20 +0100 [thread overview]
Message-ID: <1441091120.18644.149.camel@hellion.org.uk> (raw)
In-Reply-To: <1441035744-10953-1-git-send-email-hdegoede@redhat.com>
On Mon, 2015-08-31 at 17:42 +0200, Hans de Goede wrote:
> We know when u-boot is written to its own partition, in this case the
> layout always is:
>
> eb 0 spl
> eb 1 spl-backup
> eb 2 u-boot
> eb 3 u-boot-backup
>
> eb: erase-block
These are all the same size on this particular chip/all known sunxi
SoCs, right?
> So if we cannot load u-boot from its primary offset we know exactly where
> to look for it.
> +#else
> +> > /*
> +> > * u-boot-dtb.bin on its own partition, do not use syndrome, u-boot
> +> > * partition sits after 2 eraseblocks (spl, spl-backup), look for
> +> > * backup u-boot 1 erase block further.
> +> > */
> +> > const uint32_t boot_offsets[] = {
> +> > > CONFIG_SYS_NAND_U_BOOT_OFFS,
> +> > > CONFIG_SYS_NAND_U_BOOT_OFFS + CONFIG_SYS_NAND_U_BOOT_OFFS / 2,
> +> > };
> +> > const int syndrome = 0;
> +#endif
The relationship between half of SYS_NAND_U_BOOT_OFFS and an erase
block here is a bit non-obvious in this context (the offset is 2 blocks
so one block is half that).
Is there no suitable #define for the eb size which could be used here
(and ideally in the definition of U_BOOT_OFFS too)? Could we add one?
Ian.
next prev parent reply other threads:[~2015-09-01 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 15:42 [U-Boot] [PATCH] sunxi_nand_spl: Be smarter about where to look for backup u-boot.bin Hans de Goede
2015-09-01 7:05 ` Ian Campbell [this message]
2015-09-01 8:52 ` Hans de Goede
2015-09-02 8:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441091120.18644.149.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.