All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/13] sunxi: Make the fastboot buffer larger
Date: Tue, 01 Sep 2015 08:22:04 +0100	[thread overview]
Message-ID: <1441092124.18644.154.camel@hellion.org.uk> (raw)
In-Reply-To: <1441032373-16992-11-git-send-email-maxime.ripard@free-electrons.com>

On Mon, 2015-08-31 at 16:46 +0200, Maxime Ripard wrote:
> When using fastboot and flashing a larger image such as the main partition
> of a system, the current 32MB limit for the buffer is quite small.

(Apart from rooting/rescuing the odd phone I'm completely unfamiliar
with fastboot, so sorry if this is all obvious).
 
The main partition of a system these days is measured in GB, I think.
So why does going from 32MB to 256MB for the buffer make a useful
difference?

Is there some enormous per-buffer overhead which needs to be amortised?
Or is something else going on?

IOW what is the practical impact of this change?

> Increase it to something that looks decent for such a use case.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  include/configs/sunxi-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi
> -common.h
> index 1abf73c31179..710521c617f5 100644
> --- a/include/configs/sunxi-common.h
> +++ b/include/configs/sunxi-common.h
> @@ -363,7 +363,7 @@ extern int soft_i2c_gpio_scl;
>  #ifdef CONFIG_USB_FUNCTION_FASTBOOT
>  #define CONFIG_CMD_FASTBOOT
>  #define CONFIG_FASTBOOT_BUF_ADDR	CONFIG_SYS_LOAD_ADDR
> -#define CONFIG_FASTBOOT_BUF_SIZE	0x2000000
> +#define CONFIG_FASTBOOT_BUF_SIZE	(256 << 20)
>  
>  #define CONFIG_FASTBOOT_FLASH
>  #define CONFIG_FASTBOOT_FLASH_MMC_DEV	0

  parent reply	other threads:[~2015-09-01  7:22 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 14:46 [U-Boot] [PATCH 00/13] Implement fastboot over NAND Maxime Ripard
2015-08-31 14:46 ` [U-Boot] [PATCH 01/13] mtd: uboot: Add meaningful error message Maxime Ripard
2015-09-04 17:20   ` Tom Rini
2015-08-31 14:46 ` [U-Boot] [PATCH 02/13] sparse: Move main header parsing to a function of its own Maxime Ripard
2015-09-04 17:20   ` Tom Rini
2015-08-31 14:46 ` [U-Boot] [PATCH 03/13] sparse: Refactor chunk parsing function Maxime Ripard
2015-09-04 17:20   ` Tom Rini
2015-08-31 14:46 ` [U-Boot] [PATCH 04/13] sparse: Simplify multiple logic Maxime Ripard
2015-09-04 17:20   ` Tom Rini
2015-09-06 11:27     ` Maxime Ripard
2015-09-06 19:28       ` Tom Rini
2015-09-13 17:08         ` Maxime Ripard
2015-08-31 14:46 ` [U-Boot] [PATCH 05/13] sparse: Implement storage abstraction Maxime Ripard
2015-09-04 17:20   ` Tom Rini
2015-08-31 14:46 ` [U-Boot] [PATCH 06/13] fastboot: Move fastboot response functions to fastboot core Maxime Ripard
2015-09-04 17:20   ` Tom Rini
2015-09-06 16:11     ` Maxime Ripard
2015-09-06 19:43       ` Tom Rini
2015-08-31 14:46 ` [U-Boot] [PATCH 07/13] fastboot: Implement NAND backend Maxime Ripard
2015-09-04 17:20   ` Tom Rini
2015-09-06 15:57     ` Maxime Ripard
2015-09-06 19:41       ` Tom Rini
2015-09-10  7:41   ` Boris Brezillon
2015-08-31 14:46 ` [U-Boot] [PATCH 08/13] fastboot: nand: Add pre erase and write hooks Maxime Ripard
2015-09-04 17:20   ` Tom Rini
2015-08-31 14:46 ` [U-Boot] [PATCH 09/13] sparse: Rename the file and header Maxime Ripard
2015-09-04 17:21   ` Tom Rini
2015-09-06 11:28     ` Maxime Ripard
2015-08-31 14:46 ` [U-Boot] [PATCH 10/13] sunxi: Make the fastboot buffer larger Maxime Ripard
2015-08-31 15:01   ` Hans de Goede
2015-08-31 19:17     ` Rob Herring
2015-09-01  7:14       ` Maxime Ripard
2015-09-08 13:00         ` Rob Herring
2015-09-08 15:44           ` Maxime Ripard
2015-09-01  7:05     ` Maxime Ripard
2015-09-01  8:59       ` Hans de Goede
2015-09-03 21:43         ` Maxime Ripard
2015-09-01  8:02     ` Siarhei Siamashka
2015-09-01  7:22   ` Ian Campbell [this message]
2015-09-01  7:44     ` Siarhei Siamashka
2015-09-01  8:11       ` Maxime Ripard
2015-09-04 17:02       ` Tom Rini
2015-09-06 11:23         ` Maxime Ripard
2015-09-01  7:57     ` Maxime Ripard
2015-09-04 16:59       ` Tom Rini
2015-09-06 11:22         ` Maxime Ripard
2015-09-07  9:07           ` Ian Campbell
2015-08-31 14:46 ` [U-Boot] [PATCH 11/13] sunxi: Add support for android boot image Maxime Ripard
2015-09-01  7:08   ` Ian Campbell
2015-09-01  7:15     ` Maxime Ripard
2015-09-01  9:00     ` Paul Kocialkowski
2015-09-01 10:46       ` Ian Campbell
2015-09-01 11:29         ` Maxime Ripard
2015-09-01 13:54           ` Ian Campbell
2015-09-01 13:59             ` Paul Kocialkowski
2015-09-01 11:28       ` Maxime Ripard
2015-09-08 13:12     ` Rob Herring
2015-08-31 14:46 ` [U-Boot] [PATCH 12/13] sunxi: A13-Olinuxino: Enable the USB OTG controller Maxime Ripard
2015-09-01  9:01   ` Hans de Goede
2015-09-03 21:41     ` Maxime Ripard
2015-09-10 18:47       ` Hans de Goede
2015-09-13 17:13         ` Maxime Ripard
2015-09-13 17:38           ` Hans de Goede
2015-09-14 21:19             ` Maxime Ripard
2015-08-31 14:46 ` [U-Boot] [PATCH 13/13] sunxi: cubietruck: " Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441092124.18644.154.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.