From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755349AbbIAIAT (ORCPT ); Tue, 1 Sep 2015 04:00:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:36603 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754675AbbIAIAR (ORCPT ); Tue, 1 Sep 2015 04:00:17 -0400 Message-ID: <1441094336.3328.1.camel@suse.com> Subject: Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH From: Oliver Neukum To: Eugene Shatokhin Cc: =?ISO-8859-1?Q?Bj=F8rn?= Mork , David Miller , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 01 Sep 2015 09:58:56 +0200 In-Reply-To: <55E41557.1060803@rosalab.ru> References: <55AD3A41.2040100@rosalab.ru> <1440447223-15945-1-git-send-email-eugene.shatokhin@rosalab.ru> <1440447223-15945-3-git-send-email-eugene.shatokhin@rosalab.ru> <87k2sk9zaf.fsf@nemi.mork.no> <55E01750.4010202@rosalab.ru> <87mvxbzta9.fsf@nemi.mork.no> <55E03B28.6050305@rosalab.ru> <87io7vzzdl.fsf@nemi.mork.no> <55E41557.1060803@rosalab.ru> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-08-31 at 11:50 +0300, Eugene Shatokhin wrote: > > But I would have liked it much better if the code became simpler > instead > > of more complex. > > Me too, but I can see no other way here. The code is simpler without > locking, indeed, but locking is needed to prevent the problems > described > earlier. On a practical note, will you resend the patch? Regards Oliver