Re: [PATCH] x86/bigmem: eliminate struct domain address width restriction

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-08-26 at 01:41 -0600, Jan Beulich wrote:
> @@ -225,10 +226,12 @@ static unsigned int __init noinline _dom
>  
>      return bits;
>  }
> +#endif
>  
>  struct domain *alloc_domain_struct(void)
>  {
>      struct domain *d;
> +#ifndef CONFIG_BIGMEM
>      /*
>       * We pack the PDX of the domain structure into a 32-bit field 
> within
>       * the page_info structure. Hence the MEMF_bits() restriction.
> @@ -237,12 +240,16 @@ struct domain *alloc_domain_struct(void)
>  
>      if ( unlikely(!bits) )
>           bits = _domain_struct_bits();
> +#else
> +# define bits 0

const unsigned int bits = 0;

Seems nicer than the trailing #undef?

> +#endif
>  
>      BUILD_BUG_ON(sizeof(*d) > PAGE_SIZE);
>      d = alloc_xenheap_pages(0, MEMF_bits(bits));
>      if ( d != NULL )
>          clear_page(d);
>      return d;
> +#undef bits
>  }
>  
>  void free_domain_struct(struct domain *d)
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel