From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v8 2/3] Differentiate IO/mem resources tracked by ioreq server Date: Tue, 1 Sep 2015 16:38:44 +0100 Message-ID: <1441121924.26292.66.camel@citrix.com> References: <1440322398-8779-1-git-send-email-yu.c.zhang@linux.intel.com> <1440322398-8779-3-git-send-email-yu.c.zhang@linux.intel.com> <20150825094002.GL29776@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150825094002.GL29776@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Yu Zhang Cc: kevin.tian@intel.com, keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, Paul.Durrant@citrix.com, zhiyuan.lv@intel.com, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Tue, 2015-08-25 at 10:40 +0100, Wei Liu wrote: > On Sun, Aug 23, 2015 at 05:33:17PM +0800, Yu Zhang wrote: > > Currently in ioreq server, guest write-protected ram pages are > > tracked in the same rangeset with device mmio resources. Yet > > unlike device mmio, which can be in big chunks, the guest write- > > protected pages may be discrete ranges with 4K bytes each. This > > patch uses a seperate rangeset for the guest ram pages. > > > > Note: Previously, a new hypercall or subop was suggested to map > > write-protected pages into ioreq server. However, it turned out > > handler of this new hypercall would be almost the same with the > > existing pair - HVMOP_[un]map_io_range_to_ioreq_server, and there's > > already a type parameter in this hypercall. So no new hypercall > > defined, only a new type is introduced. > > > > Signed-off-by: Yu Zhang > > --- > > tools/libxc/include/xenctrl.h | 31 ++++++++++++++++++++ > > tools/libxc/xc_domain.c | 61 > > ++++++++++++++++++++++++++++++++++++++++ > > For tools bits: > > Acked-by: Wei Liu I looked at it before I saw this and as a binding for the hypercall it LGTM as well: Acked-by: Ian Campbell There appear to be no callers of these new interfaces, are those to come later? Given the trivial nature of the tools side here I'm likely not going to pay much attention to this series from now on, please drop me an explicit ping if something changes which requires my attention. Ian.