From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.6] tools: Honor Config.mk debug value, rather than setting our own Date: Wed, 2 Sep 2015 12:24:31 +0100 Message-ID: <1441193071.26292.139.camel@citrix.com> References: <1441186495-7256-1-git-send-email-george.dunlap@eu.citrix.com> <20150902110822.GE18474@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150902110822.GE18474@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , George Dunlap Cc: Ian Jackson , Roger Pau Monne , Euan Harris , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-09-02 at 12:08 +0100, Wei Liu wrote: > On Wed, Sep 02, 2015 at 10:34:55AM +0100, George Dunlap wrote: > > Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add > > macro debugging information') exposed a bug whereby the autoconf stuff > > in tools was setting its own debug value (defaulting to ENABLED, even > > for releases) instead of honoring the value set in Config.mk. > > > > After that changeset, if the global build has -D_FORTIFY_SOURCE > > enabled (as is the default in CentOS 7 rpmbuild), then the tools build > > will fail (because debug builds default to on). > > > > There should be only one place to specify whether to build debug or > > not, and Config.mk is already included by the relevant makefiles. So > > simply remove the tools/configure debug option and everything falls > > into place naturally. > > > > Signed-off-by: George Dunlap > > Acked-by: Wei Liu Release-ack too?