Re: [OSSTEST PATCH 15/13] Plan reporting: Provide get-last-plan queuedaemon command

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2015-09-03 at 12:49 +0100, Ian Jackson wrote:
> This allows retrieval, by monitoring clients which are not
> participating in the planning queue, of the finished projection, or
> the unfinished plan as it was at the time of last restart.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  README.planner |   11 +++++++++++
>  ms-queuedaemon |    8 ++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/README.planner b/README.planner
> index c1b2bf6..8231812 100644
> --- a/README.planner
> +++ b/README.planner
> @@ -224,6 +224,17 @@ ms-queuedaemon commands
>  
>  	> thought-done | thought-wait
>  
> +        > get-last-plan projection|plan
> +                Retrieve the last fully completed plan (`projection'),
> +		or the most recent short-term information used for
> +		actual resource allocation (`plan').
> +
> +		For monitoring tools, not participants in the resource
> +		allocation process.  Response is as for get-plan:
> +
> +		< OK get-plan BYTES
> +		PLAN-DATA
> +
>  
>  Plan is:
>  	Start	time_t used for "now" *
> diff --git a/ms-queuedaemon b/ms-queuedaemon
> index 222b687..97dff85 100755
> --- a/ms-queuedaemon
> +++ b/ms-queuedaemon
> @@ -292,6 +292,7 @@ proc report-plan {w wo} {
>      } emsg]} {
>          log "INTERNAL ERROR showing $w html: $emsg"
>      } else {
> +	file copy -force data-$w.pl data-$wo-final.pl

IIRC there was code earlier which did smth like "cp data-plan.pl data
-projection.pl" during the take over and that if no resources come
available during a plan walk then no projection walk would happen.

IOW a user needs to do something like try get-last-plan on projection, then
if that doesn't work try again with plan. 

But with that the last projection walk might be out of data WRT a more
recently completed plan walk.

So I think a client would need to get both and compare the timestamps or
something. It might be nicer to arrange for data-plan-final.pl to be copied
to data-projection-final.pl at the same time as data-plan.pl becomes data
-projection.pl?

>          log "$w report-plan OK"
>      }
>  }
> @@ -366,6 +367,13 @@ proc cmd/get-plan {chan desc} {
>      set plan [return-plan-to-client $chan $w]
>  }
>  
> +proc cmd/get-last-plan {chan desc w} {
> +    global walkers
> +    if {[lsearch -exact $walkers $w] < 0} { error "unknown last-plan 
> ($w)" }
> +    if {![file exists data-$w-final.pl]} { error "no last-plan $w" }
> +    return-plan-data-to-client $w-final
> +}
> +
>  proc cmd/book-resources {chan desc bytes} {
>      read-chan-data $chan $bytes do-book-resources $w
>  }