From: Joe Perches <joe@perches.com>
To: Alexey Klimov <alexey.klimov@linaro.org>
Cc: daniel.lezcano@linaro.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, yingjoe.chen@mediatek.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
klimov.linux@gmail.com
Subject: Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init
Date: Thu, 03 Sep 2015 20:40:06 -0700 [thread overview]
Message-ID: <1441338006.9666.38.camel@perches.com> (raw)
In-Reply-To: <1441336900-15095-2-git-send-email-alexey.klimov@linaro.org>
On Fri, 2015-09-04 at 06:21 +0300, Alexey Klimov wrote:
> These messages are actually errors and not warnings.
> Use pr_err() macro for them and add missing \n.
[]
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
[]
> @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node)
>
> evt = kzalloc(sizeof(*evt), GFP_KERNEL);
> if (!evt) {
> - pr_warn("Can't allocate mtk clock event driver struct");
> + pr_err("Can't allocate mtk clock event driver struct\n");
> return;
> }
Might as well remove this one as there's
a generic stack_dump() on alloc failures.
next prev parent reply other threads:[~2015-09-04 3:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 3:21 [RFC PATCH 1/3] clocksource: mtk_timer: add pr_fmt define Alexey Klimov
2015-09-04 3:21 ` [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init Alexey Klimov
2015-09-04 3:40 ` Joe Perches [this message]
2015-09-04 8:50 ` Matthias Brugger
2015-09-04 3:21 ` [RFC PATCH 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init() Alexey Klimov
[not found] ` <1441336900-15095-3-git-send-email-alexey.klimov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-04 8:39 ` Matthias Brugger
2015-09-04 8:39 ` Matthias Brugger
2015-09-04 8:51 ` [RFC PATCH 1/3] clocksource: mtk_timer: add pr_fmt define Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441338006.9666.38.camel@perches.com \
--to=joe@perches.com \
--cc=alexey.klimov@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=tglx@linutronix.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.