From: Johannes Berg <johannes@sipsolutions.net>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mac80211: Do not use sizeof() on pointer type
Date: Fri, 04 Sep 2015 14:24:48 +0200 [thread overview]
Message-ID: <1441369488.1971.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1440584534-27251-1-git-send-email-thierry.reding@gmail.com> (sfid-20150826_122335_049759_FB67F67D)
On Wed, 2015-08-26 at 12:22 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The rate_control_cap_mask() function takes a parameter mcs_mask,
> which
> GCC will take to be u8 * even though it was declared with a fixed
> size.
> This causes the following warning:
>
> net/mac80211/rate.c: In function 'rate_control_cap_mask':
> net/mac80211/rate.c:719:25: warning: 'sizeof' on array
> function parameter 'mcs_mask' will return size of 'u8 * {aka unsigned
> char *}' [-Wsizeof-array-argument]
> for (i = 0; i < sizeof(mcs_mask); i++)
> ^
> net/mac80211/rate.c:684:10: note: declared here
> u8 mcs_mask[IEEE80211_HT_MCS_MASK_LEN],
> ^
>
> This can be easily fixed by using the IEEE80211_HT_MCS_MASK_LEN
> directly
> within the loop condition.
Dunno if you (Thierry) saw all the discussion about this - but anyway,
applied, thanks.
johannes
prev parent reply other threads:[~2015-09-04 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 10:22 [PATCH] mac80211: Do not use sizeof() on pointer type Thierry Reding
2015-08-26 10:22 ` Thierry Reding
2015-08-26 20:23 ` Arend van Spriel
2015-08-26 20:40 ` Arend van Spriel
2015-09-04 12:24 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441369488.1971.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.