From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] x86/NUMA: make init_node_heap() respect Xen
 heap limit
Date: Fri, 4 Sep 2015 13:52:42 +0100
Message-ID: <1441371162.26292.488.camel@citrix.com>
References: <55DEE85D020000780009D4FA@prv-mh.provo.novell.com>
	<55E8A716.3080109@citrix.com> <55E8B45A.2040909@citrix.com>
	<55E96652020000780009F81F@prv-mh.provo.novell.com>
	<1441355255.26292.417.camel@citrix.com>
	<55E974C7020000780009F8A4@prv-mh.provo.novell.com>
	<1441356769.26292.430.camel@citrix.com>
	<55E97BD8020000780009F8D5@prv-mh.provo.novell.com>
	<55E980B7.4090100@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6823cdc95=Ian.Campbell@citrix.com>)
	id 1ZXqU2-0005gr-Nd
	for xen-devel@lists.xenproject.org; Fri, 04 Sep 2015 12:52:46 +0000
In-Reply-To: <55E980B7.4090100@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>, IanJackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

> commit b11ab8e4982228d7944e11010f5b8eec890caf30
> Author: Julien Grall <julien.grall@citrix.com>
> Date:   Thu Sep 3 21:49:31 2015 +0100
> 
>     xen: pagealloc: Correctly calculate the number of xenheap bits

More accurate would be

    xen: arm64: do not (incorrectly) limit size of xenheap

Or some such?

With that:
    Acked-by: Ian Campbell <ian.campbell@citrix.com>

Will you resend as a "git am" able thing please?

>     
>     The commit 88e3ed61642bb393458acc7a9bd2f96edc337190 "x86/NUMA: make
>     init_node_heap() respect Xen heap limit" breaks boot on the arm64 board
>     X-Gene.
>     
>     The xenheap bits variable is used to know the last RAM MFN always mapped
>     in Xen virtual memory. If the value is 0, it means that all the memory is
>     always mapped in Xen virtual memory.
>     
>     On X-gene the RAM bank resides above 128GB and last xenheap MFN is
>     0x4400000. With the new way to calculate the number of bits, xenheap_bits
>     will be equal to 38 bits. This will result to hide all the RAM and the
>     impossibility to allocate xenheap memory.
>     
>     Given that aarch64 have always all the memory mapped in Xen virtual
>     memory, it's not necessary to call xenheap_max_mfn which set the number
>     of bits.
>     
>     Suggested-by: Jan Beulich <jbeulich@suse.com>
>     Signed-off-by: Julien Grall <julien.grall@citrix.com>
> 
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 6626eba..48f734f 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -665,7 +665,6 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size)
>      xenheap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start;
>      xenheap_mfn_start = ram_start >> PAGE_SHIFT;
>      xenheap_mfn_end = ram_end >> PAGE_SHIFT;
> -    xenheap_max_mfn(xenheap_mfn_end);
>  
>      /*
>       * Need enough mapped pages for copying the DTB.