From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen/arm64: do not (incorrectly) limit size of xenheap Date: Fri, 4 Sep 2015 15:40:26 +0100 Message-ID: <1441377626.26292.522.camel@citrix.com> References: <1441371420-5648-1-git-send-email-julien.grall@citrix.com> <20150904131627.GD27133@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZXsAI-0004tg-ON for xen-devel@lists.xenproject.org; Fri, 04 Sep 2015 14:40:30 +0000 In-Reply-To: <20150904131627.GD27133@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Julien Grall Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, Jan Beulich List-Id: xen-devel@lists.xenproject.org On Fri, 2015-09-04 at 14:16 +0100, Wei Liu wrote: > On Fri, Sep 04, 2015 at 01:57:00PM +0100, Julien Grall wrote: > > The commit 88e3ed61642bb393458acc7a9bd2f96edc337190 "x86/NUMA: make > > init_node_heap() respect Xen heap limit" breaks boot on the arm64 board > > X-Gene. > > > > The xenheap bits variable is used to know the last RAM MFN always > > mapped > > in Xen virtual memory. If the value is 0, it means that all the memory > > is > > always mapped in Xen virtual memory. > > > > On X-gene the RAM bank resides above 128GB and last xenheap MFN is > > 0x4400000. With the new way to calculate the number of bits, > > xenheap_bits > > will be equal to 38 bits. This will result to hide all the RAM and the > > impossibility to allocate xenheap memory. > > > > Given that aarch64 have always all the memory mapped in Xen virtual > > memory, it's not necessary to call xenheap_max_mfn which set the number > > of bits. > > > > Suggested-by: Jan Beulich > > Signed-off-by: Julien Grall > > Acked-by: Ian Campbell > > > > Release-acked-by: Wei Liu Applied.