From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Paul Durrant <paul.durrant@citrix.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH v2] public/io/netif.h: move and amend multicast control documentation
Date: Fri, 4 Sep 2015 15:41:42 +0100 [thread overview]
Message-ID: <1441377702.26292.527.camel@citrix.com> (raw)
In-Reply-To: <20150904132211.GA25537@zion.uk.xensource.com>
On Fri, 2015-09-04 at 14:22 +0100, Wei Liu wrote:
> On Wed, Sep 02, 2015 at 12:17:05PM +0100, Paul Durrant wrote:
> > netif.h contains a specification of the
> > XEN_NETIF_EXTRA_TYPE_MCAST_{ADD,DEL}
> > extra info messages require to manipulate a multicast filter list
> > maintained
> > by a backend and specifies the xenstore negotiation protocol in a
> > comment
> > just above the structure defintion, which is easy to miss.
> >
> > This patch moves the documentation of the xenstore negotiation to be
> > co-located with the documentation for other features and also amends
> > the
> > wording to be clearer.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Jan Beulich <jbeulich@suse.com>
> > Cc: Keir Fraser <keir@xen.org>
> > Cc: Tim Deegan <tim@xen.org>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Applied, with:
> > + * connected state.
>
> I would prefer adding a blank line here if possible.
"\n *" added.
next prev parent reply other threads:[~2015-09-04 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 11:17 [PATCH v2] public/io/netif.h: move and amend multicast control documentation Paul Durrant
2015-09-04 13:22 ` Wei Liu
2015-09-04 14:41 ` Ian Campbell [this message]
2015-09-04 14:42 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441377702.26292.527.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=paul.durrant@citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.