All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PULL 01/16] qemu-iotests: qemu machine type support
Date: Fri,  4 Sep 2015 22:10:32 +0200	[thread overview]
Message-ID: <1441397447-6516-2-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1441397447-6516-1-git-send-email-kwolf@redhat.com>

From: Bo Tu <tubo@linux.vnet.ibm.com>

This patch adds qemu machine type support to the io test suite.
Based on the qemu default machine type and alias of the default machine
type the reference output file can now vary from the default to a
machine specific output file if necessary. When using a machine specific
reference file if the default machine has an alias then use the alias as the output
file name otherwise use the default machine name as the output file name.

Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Michael Mueller <mimu@linux.vnet.ibm.com>
Reviewed-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/qemu-iotests/check         |  5 +++++
 tests/qemu-iotests/common.config | 11 ++++++++++-
 tests/qemu-iotests/iotests.py    |  1 +
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 1fa6319..6d58203 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -330,6 +330,11 @@ do
             fi
 
             reference="$source_iotests/$seq.out"
+            reference_machine="$source_iotests/$seq.$QEMU_DEFAULT_MACHINE.out"
+            if [ -f "$reference_machine" ]; then
+                reference="$reference_machine"
+            fi
+
             if [ "$CACHEMODE" = "none" ]; then
                 [ -f "$source_iotests/$seq.out.nocache" ] && reference="$source_iotests/$seq.out.nocache"
             fi
diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config
index a1973ad..e0bf896 100644
--- a/tests/qemu-iotests/common.config
+++ b/tests/qemu-iotests/common.config
@@ -103,10 +103,19 @@ if [ -z "$QEMU_NBD_PROG" ]; then
     export QEMU_NBD_PROG="`set_prog_path qemu-nbd`"
 fi
 
-export QEMU=$QEMU_PROG
+export QEMU="$QEMU_PROG $QEMU_OPTIONS"
 export QEMU_IMG=$QEMU_IMG_PROG
 export QEMU_IO="$QEMU_IO_PROG $QEMU_IO_OPTIONS"
 export QEMU_NBD=$QEMU_NBD_PROG
+default_machine=$($QEMU -machine \? | awk '/(default)/{print $1}')
+default_alias_machine=$($QEMU -machine \? |\
+    awk -v var_default_machine="$default_machine"\)\
+    '{if ($(NF-2)=="(alias"&&$(NF-1)=="of"&&$(NF)==var_default_machine){print $1}}')
+if [ ! -z "$default_alias_machine" ]; then
+    default_machine="$default_alias_machine"
+fi
+
+export QEMU_DEFAULT_MACHINE="$default_machine"
 
 [ -f /etc/qemu-iotest.config ]       && . /etc/qemu-iotest.config
 
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 8615b10..5579253 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -42,6 +42,7 @@ imgproto = os.environ.get('IMGPROTO', 'file')
 test_dir = os.environ.get('TEST_DIR', '/var/tmp')
 output_dir = os.environ.get('OUTPUT_DIR', '.')
 cachemode = os.environ.get('CACHEMODE')
+qemu_default_machine = os.environ.get('QEMU_DEFAULT_MACHINE')
 
 socket_scm_helper = os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_helper')
 
-- 
1.8.3.1

  reply	other threads:[~2015-09-04 20:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 20:10 [Qemu-devel] [PULL 00/16] Block patches Kevin Wolf
2015-09-04 20:10 ` Kevin Wolf [this message]
2015-09-04 20:10 ` [Qemu-devel] [PULL 02/16] qemu-iotests: disable default qemu devices for cross-platform compatibility Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 03/16] qemu-iotests: s390x: fix test 041 and 055 Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 04/16] qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 05/16] qemu-iotests: s390x: fix test 130 Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 06/16] block/raw-posix: Use raw_normalize_devicepath() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 07/16] qemu-img: Fix crash in amend invocation Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 08/16] iotests: More options for VM.add_drive() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 09/16] iotests: Respect -nodefaults in tests 41 and 55 Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 10/16] iotests: Do not suppress segfaults in bash tests Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 11/16] iotests: Warn if python subprocess is killed Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 12/16] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 13/16] qcow2: add option to clean unused cache entries after some time Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 14/16] docs: document how to configure the qcow2 L2/refcount caches Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 15/16] qcow2: reorder fields in Qcow2CachedTable to reduce padding Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 16/16] quorum: validate vote threshold against num_children even if read-pattern is fifo Kevin Wolf
2015-09-07 12:18 ` [Qemu-devel] [PULL 00/16] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441397447-6516-2-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.