All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Nick Warne <nick@linicks.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/core/sysctl_net_core.c  unused variable
Date: Sun, 06 Sep 2015 07:52:28 -0700	[thread overview]
Message-ID: <1441551148.28194.40.camel@perches.com> (raw)
In-Reply-To: <55EC4A03.905@linicks.net>

On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote:
> gcc version 4.8.2 (GCC) warns that 'static int one = 1;' is declared but 
> not used in file net/core/sysctl_net_core.c.

Only when CONFIG_NET isn't set.

> Reading the file, that is 
> the case.  Attached is a patch to remove it.

$ git grep -w -n one net/core/sysctl_net_core.c
net/core/sysctl_net_core.c:26:static int one = 1;
net/core/sysctl_net_core.c:332:         .extra2         = &one

> Signed-off-by:  Nick Warne <nick@linicks.net>

Please use grep to augment reading.


  reply	other threads:[~2015-09-06 14:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-06 14:13 [PATCH] net/core/sysctl_net_core.c unused variable Nick Warne
2015-09-06 14:52 ` Joe Perches [this message]
2015-09-06 15:16   ` Nick Warne
     [not found]     ` <1441553310.28194.44.camel@perches.com>
2015-09-06 15:36       ` Nick Warne
2015-09-06 15:51         ` Joe Perches
2015-09-06 16:08           ` Nick Warne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441551148.28194.40.camel@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@linicks.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.