From: Peter Mamonov <pmamonov@gmail.com>
To: l.stach@pengutronix.de, s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org, Peter Mamonov <pmamonov@gmail.com>
Subject: [PATCHv3] ata: intf_platform_ide: add OF bindings
Date: Mon, 7 Sep 2015 19:43:53 +0300 [thread overview]
Message-ID: <1441644233-26311-1-git-send-email-pmamonov@gmail.com> (raw)
In-Reply-To: <1441641223.28391.11.camel@pengutronix.de>
Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
---
drivers/ata/intf_platform_ide.c | 34 +++++++++++++++++++++++++++++-----
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/drivers/ata/intf_platform_ide.c b/drivers/ata/intf_platform_ide.c
index 0d392d8..ab633c0 100644
--- a/drivers/ata/intf_platform_ide.c
+++ b/drivers/ata/intf_platform_ide.c
@@ -29,6 +29,7 @@
#include <ata_drive.h>
#include <platform_ide.h>
#include <linux/err.h>
+#include <of.h>
/**
* Setup the register specific addresses for an ATA like divice
@@ -85,8 +86,22 @@ static int platform_ide_probe(struct device_d *dev)
void *reg_base, *alt_base = NULL;
struct resource *reg, *alt;
int mmio = 0;
-
- if (pdata == NULL) {
+ struct device_node *dn = dev->device_node;
+ unsigned ioport_shift = 0;
+ int dataif_be = 0;
+ void (*reset)(int) = NULL;
+
+ if (pdata) {
+ ioport_shift = pdata->ioport_shift;
+ dataif_be = pdata->dataif_be;
+ reset = pdata->reset;
+ } else if (dn) {
+ /* try to get platform data from the device tree */
+ u32 tmp32;
+
+ if (of_property_read_u32(dn, "reg-shift", &tmp32) == 0)
+ ioport_shift = (unsigned)tmp32;
+ } else {
dev_err(dev, "No platform data. Cannot continue\n");
return -EINVAL;
}
@@ -123,9 +138,9 @@ static int platform_ide_probe(struct device_d *dev)
ide = xzalloc(sizeof(*ide));
ide->io.mmio = mmio;
- platform_ide_setup_port(reg_base, alt_base, &ide->io, pdata->ioport_shift);
- ide->io.reset = pdata->reset;
- ide->io.dataif_be = pdata->dataif_be;
+ platform_ide_setup_port(reg_base, alt_base, &ide->io, ioport_shift);
+ ide->io.reset = reset;
+ ide->io.dataif_be = dataif_be;
rc = ide_port_register(ide);
if (rc != 0) {
@@ -136,9 +151,18 @@ static int platform_ide_probe(struct device_d *dev)
return rc;
}
+static __maybe_unused struct of_device_id platform_ide_dt_ids[] = {
+ {
+ .compatible = "ata-generic",
+ }, {
+ /* sentinel */
+ }
+};
+
static struct driver_d platform_ide_driver = {
.name = "ide_intf",
.probe = platform_ide_probe,
+ .of_compatible = DRV_OF_COMPAT(platform_ide_dt_ids),
};
device_platform_driver(platform_ide_driver);
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-09-07 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 13:38 [PATCH] ata: intf_platform_ide: add OF bindings Peter Mamonov
2015-09-03 14:24 ` Antony Pavlov
2015-09-03 15:33 ` Peter Mamonov
2015-09-03 16:04 ` Peter Mamonov
2015-09-03 18:13 ` Sascha Hauer
2015-09-07 15:44 ` [PATCHv2] " Peter Mamonov
2015-09-07 15:53 ` Lucas Stach
2015-09-07 16:43 ` Peter Mamonov [this message]
2015-09-09 6:54 ` [PATCHv3] " Sascha Hauer
2015-09-03 15:46 ` [PATCH] " Lucas Stach
2015-09-03 16:31 ` Antony Pavlov
2015-09-03 18:16 ` Sascha Hauer
2015-09-04 10:15 ` Peter Mamonov
2015-09-04 9:40 ` Peter Mamonov
2015-09-04 10:23 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441644233-26311-1-git-send-email-pmamonov@gmail.com \
--to=pmamonov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.