From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "sergei.shtylyov@cogentembedded.com"
<sergei.shtylyov@cogentembedded.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] stmmac: fix check for phydev being open
Date: Mon, 7 Sep 2015 21:26:20 +0000 [thread overview]
Message-ID: <1441661180.4998.5.camel@synopsys.com> (raw)
In-Reply-To: <55EE008E.6040405@cogentembedded.com>
Hi Sergei,
On Tue, 2015-09-08 at 00:24 +0300, Sergei Shtylyov wrote:
> On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
>
> > Current implementation via IS_ERR(phydev) may make no sense because
> > of_phy_attach() returns NULL on failure instead of error value.
>
> Not of_phy_connect()?
I already noticed this misspelling - it came from my exploration of
what happens inside of_phy_connect(). So sort of braindump.
I will fix in v3 re-spin.
-Alexey
prev parent reply other threads:[~2015-09-07 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 20:50 [PATCH v2] stmmac: fix check for phydev being open Alexey Brodkin
2015-09-07 20:53 ` Sergei Shtylyov
2015-09-07 21:08 ` Alexey Brodkin
2015-09-07 21:24 ` Sergei Shtylyov
2015-09-07 21:26 ` Alexey Brodkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441661180.4998.5.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.