From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6 00/11] Extract TLS handling code from VNC server
Date: Tue, 08 Sep 2015 13:24:19 +0200 [thread overview]
Message-ID: <1441711459.27149.44.camel@redhat.com> (raw)
In-Reply-To: <55EEB29B.6090108@redhat.com>
Hi,
> I think the patches are great, and I'm not sure if anyone is in a better
> position than you to decide if they're ready.
Lets have a look:
# scripts/get_maintainer.pl -f crypto
"Daniel P. Berrange" <berrange@redhat.com> (maintainer:Cryptography)
> I don't even know if anyone really understands the VNC TLS code and
> thus can review patch 11. :) So I would just ask you to send a pull
> request.
Agree. Don't be shy, send a pull request. Including the vnc bits is
fine with me. I've briefly looked over the vnc changes, they look sane
to me, and consolidating all the crypto stuff in a nice, reusable way
instead of sprinkling gnutls ifdefs all over the place (including vnc)
certainly is a step into the right direction.
cheers,
Gerd
prev parent reply other threads:[~2015-09-08 11:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 11:17 [Qemu-devel] [PATCH v6 00/11] Extract TLS handling code from VNC server Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 01/11] qapi: allow override of default enum prefix naming Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 02/11] tests: remove repetition in unit test object deps Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 03/11] crypto: move crypto objects out of libqemuutil.la Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 04/11] qom: allow QOM to be linked into tools binaries Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 05/11] crypto: introduce new base module for TLS credentials Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 06/11] crypto: introduce new module for TLS anonymous credentials Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 07/11] crypto: introduce new module for TLS x509 credentials Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 08/11] crypto: add sanity checking of " Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 09/11] crypto: introduce new module for handling TLS sessions Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 10/11] ui: fix return type for VNC I/O functions to be ssize_t Daniel P. Berrange
2015-09-02 11:18 ` [Qemu-devel] [PATCH v6 11/11] ui: convert VNC server to use QCryptoTLSSession Daniel P. Berrange
2015-09-08 10:04 ` [Qemu-devel] [PATCH v6 00/11] Extract TLS handling code from VNC server Paolo Bonzini
2015-09-08 11:24 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441711459.27149.44.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.