Re: [PATCH OSSTEST v2 4/6] ts-openstack-devstack: Deploy OpenStack on a host

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2015-08-06 at 18:03 +0100, Anthony PERARD wrote:
> This script also install packages needed and clone every OpenStack trees to
> be use by devstack to deploy OpenStack.

How about:

This script installs any necessary packages and clones all of the OpenStack
trees which are used by devstack to deploy OpenStack

> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  sg-run-job            |   5 +
>  ts-openstack-devstack | 304
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 309 insertions(+)
>  create mode 100755 ts-openstack-devstack
> 
> diff --git a/sg-run-job b/sg-run-job
> index b7ab9e0..5320d62 100755
> --- a/sg-run-job
> +++ b/sg-run-job
> @@ -360,6 +360,11 @@ proc run-job/test-rumpuserxen {} {
>                   ts-guest-destroy-hard            host   $g   +
>  }
>  
> +proc need-hosts/test-devstack {} { return host }
> +proc run-job/test-devstack {} {
> +  run-ts . = ts-openstack-devstack

I think you need " host" at the end of this line, in order that it gets
passed to the script as an argument, don't you?

> +}
> +
>  #---------- builds ----------
>  
>  proc need-hosts/build {} { return BUILD }
> diff --git a/ts-openstack-devstack b/ts-openstack-devstack
> new file mode 100755
> index 0000000..8bcd322
> --- /dev/null
> +++ b/ts-openstack-devstack
> @@ -0,0 +1,304 @@
> 
[...]+
> +tsreadconfig();
> +our ($ho,$gho) = ts_get_host_guest(@ARGV);

I don't think you use $gho and sg-run-job doesn't pass one, so I think you
just need to use selecthost.

> [...]
> +  my $openstack_git_base = git_massage_url('git://git.openstack.org');
> [...]
> +GIT_BASE="$openstack_git_base"

Does this suggest that it might try and clone anything which it can't find
(i.e. which wasn't cloned by your list of clones), which would defeat the
purpose of controlling the trees.

If this auto-cloning is not desirable then perhaps GIT_BASE should be set
to some dummy value, "git://cache/this-shouldnt-exist" or some other bodge
perhaps?

I think you also need to call store_revision for each tree (including any
you don't explicitly clone here) at the end to record the actual versions
which were built.

> +disable_service horizon
> +disable_service n-novnc
> +enable_service n-obj
> +[[post-config|\$CINDER_CONF]]
> +[lvmdriver-1]
> +volume_group = $vg
> +END
> +
> +  # libvirt is already install, but not as a package, so avoid


"installed"