From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v2 5/6] ts-openstack-tempest: Run
 Tempest to check OpenStack
Date: Tue, 8 Sep 2015 14:06:11 +0100
Message-ID: <1441717571.24450.89.camel@citrix.com>
References: <1438880611-13244-1-git-send-email-anthony.perard@citrix.com>
	<1438880611-13244-6-git-send-email-anthony.perard@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1438880611-13244-6-git-send-email-anthony.perard@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-08-06 at 18:03 +0100, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  sg-run-job           |  1 +
>  ts-openstack-tempest | 35 +++++++++++++++++++++++++++++++++++
>  2 files changed, 36 insertions(+)
>  create mode 100755 ts-openstack-tempest
> 
> diff --git a/sg-run-job b/sg-run-job
> index 5320d62..0b2184b 100755
> --- a/sg-run-job
> +++ b/sg-run-job
> @@ -363,6 +363,7 @@ proc run-job/test-rumpuserxen {} {
>  proc need-hosts/test-devstack {} { return host }
>  proc run-job/test-devstack {} {
>    run-ts . = ts-openstack-devstack
> +  run-ts . = ts-openstack-tempest

As before I think you need "host"
>  }
>  
>  #---------- builds ----------
> diff --git a/ts-openstack-tempest b/ts-openstack-tempest
> new file mode 100755
> index 0000000..2bc07c3
> --- /dev/null
> +++ b/ts-openstack-tempest
> @@ -0,0 +1,35 @@
> +#!/usr/bin/perl
> +# This is part of "osstest", an automated testing framework for Xen.
> +# Copyright (C) 2015 Citrix Inc.
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU Affero General Public License as
> published by
> +# the Free Software Foundation, either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU Affero General Public License for more details.
> +#
> +# You should have received a copy of the GNU Affero General Public
> License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +use strict qw(vars);
> +use Osstest;
> +use Osstest::TestSupport;
> +use Osstest::BuildSupport;
> +
> +tsreadconfig();
> +our ($ho,$gho) = ts_get_host_guest(@ARGV);

And here like before just selecthost since you don't use $gho

> +builddirsprops();
> +
> +sub tempest() {
> +  # The regex is the default one + avoid the two tests know to not work
> +  # which are two variations of test_volume_boot_pattern.
> +  target_cmd($ho, <<END, 7200);
> +    $builddir/tempest/run_tempest.sh

Is $builddir here inherited from the previous script? I'm not sure how that
works?


>  -V -- --concurrency=2
> '(?!.*\\[.*\\bslow\\b.*\\]|.*test_volume_boot_pattern)(^tempest\\.(api|sc
> enario|thirdparty))'

I think think ought to at least be in a variable with a comment explaining
why each one is omitted.

It could go into a runvar, but I'm not too sure about that.


> +END
> +}
> +
> +tempest();