From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless@vger.kernel.org
Cc: nbd@openwrt.org
Subject: Re: [PATCH 2/2] mac80211: Copy tx'ed beacons to monitor mode
Date: Tue, 08 Sep 2015 18:42:08 +0200 [thread overview]
Message-ID: <1441730528.1906.19.camel@sipsolutions.net> (raw)
In-Reply-To: <1441193011-2040-2-git-send-email-helmut.schaa@googlemail.com> (sfid-20150902_132536_818116_B46E2197)
I applied patch 1, but
> + /* send a copy to monitor interfaces */
> + if (!ieee80211_hw_check(hw, BEACON_TX_STATUS) &&
> + hw_to_local(hw)->monitors) {
> + struct sk_buff *copy = skb_copy(bcn, GFP_ATOMIC);
> + if (copy) {
> + shift = ieee80211_vif_get_shift(vif);
> + sband = hw->wiphy
> ->bands[ieee80211_get_sdata_band(vif_to_sdata(vif))];
> + ieee80211_tx_monitor(hw_to_local(hw), copy,
> sband, 1, shift, false);
> + }
> + }
> +
>
Please add a blank line after declarations and try to get shorter lines
here.
johannes
next prev parent reply other threads:[~2015-09-08 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 11:23 [PATCH 1/2] mac80211: Split sending tx'ed frames to monitor interfaces into its own function Helmut Schaa
2015-09-02 11:23 ` [PATCH 2/2] mac80211: Copy tx'ed beacons to monitor mode Helmut Schaa
2015-09-08 16:42 ` Johannes Berg [this message]
2015-09-09 7:46 ` [PATCHv2] " Helmut Schaa
2015-09-18 9:07 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441730528.1906.19.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.