From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id B8EFC65CBF for ; Tue, 8 Sep 2015 22:37:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t88Mb50e012484 for ; Tue, 8 Sep 2015 23:37:05 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i4_6hhjjYTPn for ; Tue, 8 Sep 2015 23:37:05 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t88Man8u012472 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 8 Sep 2015 23:37:00 +0100 Message-ID: <1441751809.24871.294.camel@linuxfoundation.org> From: Richard Purdie To: bitbake-devel Date: Tue, 08 Sep 2015 23:36:49 +0100 X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Subject: [PATCH] bitbake-worker: Simple code cleanup X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2015 22:37:06 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit start/end are unused here and we can improve the code conditional blocks. Signed-off-by: Richard Purdie diff --git a/bitbake/bin/bitbake-worker b/bitbake/bin/bitbake-worker index 305f87c..df59953 100755 --- a/bitbake/bin/bitbake-worker +++ b/bitbake/bin/bitbake-worker @@ -296,13 +296,12 @@ class BitbakeWorker(object): def serve(self): while True: (ready, _, _) = select.select([self.input] + [i.input for i in self.build_pipes.values()], [] , [], 1) - if self.input in ready or len(self.queue): - start = len(self.queue) + if self.input in ready: try: self.queue = self.queue + self.input.read() except (OSError, IOError): pass - end = len(self.queue) + if len(self.queue): self.handle_item("cookerconfig", self.handle_cookercfg) self.handle_item("workerdata", self.handle_workerdata) self.handle_item("runtask", self.handle_runtask)