From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] spi: cadence_qspi: Ensure check for max frequency in place
Date: Wed, 9 Sep 2015 23:59:57 -0500 [thread overview]
Message-ID: <1441861197.1946.4.camel@clsee-VirtualBox> (raw)
In-Reply-To: <CAD6G_RSa-oKCMqys2H2fmkop1DNaz0kR-BzVtEkQqX5XJ4yxKQ@mail.gmail.com>
Hi,
On Tue, 2015-09-08 at 17:51 +0530, Jagan Teki wrote:
> On 8 September 2015 at 06:48, Chin Liang See <clsee@altera.com> wrote:
> > Ensure the intended SCLK frequency not exceeding the maximum
> > frequency. If that happen, SCLK will set to maximum frequency.
> >
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > Cc: Vikas Manocha <vikas.manocha@st.com>
> > Cc: Jagannadh Teki <jteki@openedev.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > ---
> > drivers/spi/cadence_qspi.c | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
> > index 8c0f7dd..f430b5d 100644
> > --- a/drivers/spi/cadence_qspi.c
> > +++ b/drivers/spi/cadence_qspi.c
> > @@ -127,6 +127,11 @@ static int cadence_spi_set_speed(struct udevice *bus, uint hz)
> > struct cadence_spi_priv *priv = dev_get_priv(bus);
> > int err;
> >
> > + if (hz > plat->max_hz) {
> > + hz = plat->max_hz;
> > + puts("SF: Default to maximum supported SCLK frequency\n");
>
> This print mayn't require just assign plat->max_hz enough.
Sure, I can update that.
Thanks
Chin Liang
>
> Reviewed-by: Jagan Teki <jteki@openedev.com>
>
> > + }
> > +
> > /* Disable QSPI */
> > cadence_qspi_apb_controller_disable(priv->regbase);
>
> thanks!
next prev parent reply other threads:[~2015-09-10 4:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 1:18 [U-Boot] [PATCH 3/4] spi: cadence_qspi: Ensure check for max frequency in place Chin Liang See
2015-09-08 12:21 ` Jagan Teki
2015-09-10 4:59 ` Chin Liang See [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-03 13:41 [U-Boot] [PATCH 1/4] spi: cadence_qspi: Ensure spi_calibration is run when sclk change Chin Liang See
2015-09-03 13:42 ` [U-Boot] [PATCH 3/4] spi: cadence_qspi: Ensure check for max frequency in place Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441861197.1946.4.camel@clsee-VirtualBox \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.