From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for 4.6] configure: don't silently disable
 systemd support
Date: Thu, 10 Sep 2015 11:54:16 +0100
Message-ID: <1441882456.24450.371.camel@citrix.com>
References: <1441838125-19812-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=688ac6705=Ian.Campbell@citrix.com>)
	id 1ZZzUj-0007Z0-U1
	for xen-devel@lists.xenproject.org; Thu, 10 Sep 2015 10:54:22 +0000
In-Reply-To: <1441838125-19812-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-09-09 at 23:35 +0100, Wei Liu wrote:
> Originally when user runs ./configure --enable-systemd and systemd
> development library is not available the build system silently disables
> systemd support. This is not in line with normal expectation.
> 
> Instead, configure should error out when user has asked for systemd
> support but development libraries can't be found.
> 
> Reported-by: George Dunlap <george.dunlap@eu.citrix.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Please rerun ./autogen.sh.
> ---
>  m4/systemd.m4 | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/m4/systemd.m4 b/m4/systemd.m4
> index 8284993..84508a1 100644
> --- a/m4/systemd.m4
> +++ b/m4/systemd.m4
> @@ -85,7 +85,11 @@ AC_DEFUN([AX_CHECK_SYSTEMD], [
>  		AC_DEFINE([HAVE_SYSTEMD], [1], [Systemd available and
> enabled])
>  			systemd=y
>  			AX_CHECK_SYSTEMD_LIBS()
> -	    ],[systemd=n])
> +	    ],[
> +> 	> 	> AS_IF([test "x$enable_systemd" != "x"],

At this point the value of enable_systemd is either empty or ...what...? I
think "yes"?, with "no" having been ruled out earlier?

Or can it be just "y"?

I could live with this version, but I think it would be less of a brain ben
der if the check was inverted to be "x$enable_systemd" = "xyes" i.e. more
explicit.

Ian.