From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 5/5] virtgpu: mark as a render gpu Date: Thu, 10 Sep 2015 16:52:45 +0200 Message-ID: <1441896765.11233.25.camel@redhat.com> References: <1441798946-26233-1-git-send-email-kraxel@redhat.com> <1441798946-26233-6-git-send-email-kraxel@redhat.com> <1441895002.11233.6.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40B426E193 for ; Thu, 10 Sep 2015 07:52:49 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Dave Airlie , open list , ML dri-devel , "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org ICBIaSwKCj4gPiBEYXZlPyAgTG9va2luZyBhdCB0aGUgaW9jdGxzIHRoZXkgYXJlIGFsbCBmaW5l IGZvciByZW5kZXIgbm9kZXMsIHRoZXJlCj4gPiBpc24ndCBhbnl0aGluZyBtb2Rlc2V0dGluZyBy ZWxhdGVkIGluIHRoZSBkZXZpY2Utc3BlY2lmaWMgaW9jdGxzLgo+ID4KPiA+IENvcnJlY3Q/Cj4g Pgo+IFVubGVzcyBJJ3ZlIG92ZXJkb25lIHRoZSBjb2ZmZWUgdGhpcyB0aW1lIC0gbW9kZXNldHRp bmcgaXMgZG9uZSB2aWEKPiB0aGUgY2FyZCMgbm9kZSwgd2hpbGUgcmVuZGVyIHZpYSBlaXRoZXIg Y2FyZCMgb3IgcmVuZGVyRCMuCgpFeGFjdGx5LCB0aGF0cyB3aHkgYW55dGhpbmcgbW9kZXNldHRp bmctcmVsYXRlZCBtdXN0IGJlIGRpc2FibGVkIGZvcgpyZW5kZXJEIy4gIExvb2tpbmcgYXQgdGhl IHZpcnRpby1ncHUgZGV2aWNlLXNwZWNpZmljIGlvY3RscyBJIGRvbid0CnRoaW5rIHRoZXJlIGlz IGFueXRoaW5nIGRvaW5nIG1vZGVzZXR0aW5nICh3aGljaCB3ZSB3b3VsZCBoYXZlIHRvIGxlYXZl Cm91dCksIHNvIHdlIGNhbiBhcHBseSBEUk1fUkVOREVSX0FMTE9XIGV2ZXJ5dGhlcmUgSSB0aGlu ay4gIE9yIG1heWJlCnRoZXJlIGlzIGEgZ2xvYmFsIHN3aXRjaCB0byBmbGlwIERSTV9SRU5ERVJf QUxMT1cgZm9yIHRoZSB3aG9sZSBsaXN0IC4uLgoKY2hlZXJzLAogIEdlcmQKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbbIJOwu (ORCPT ); Thu, 10 Sep 2015 10:52:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39389 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752894AbbIJOws (ORCPT ); Thu, 10 Sep 2015 10:52:48 -0400 Message-ID: <1441896765.11233.25.camel@redhat.com> Subject: Re: [PATCH 5/5] virtgpu: mark as a render gpu From: Gerd Hoffmann To: Emil Velikov Cc: ML dri-devel , Dave Airlie , open list , "open list:VIRTIO GPU DRIVER" Date: Thu, 10 Sep 2015 16:52:45 +0200 In-Reply-To: References: <1441798946-26233-1-git-send-email-kraxel@redhat.com> <1441798946-26233-6-git-send-email-kraxel@redhat.com> <1441895002.11233.6.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > Dave? Looking at the ioctls they are all fine for render nodes, there > > isn't anything modesetting related in the device-specific ioctls. > > > > Correct? > > > Unless I've overdone the coffee this time - modesetting is done via > the card# node, while render via either card# or renderD#. Exactly, thats why anything modesetting-related must be disabled for renderD#. Looking at the virtio-gpu device-specific ioctls I don't think there is anything doing modesetting (which we would have to leave out), so we can apply DRM_RENDER_ALLOW everythere I think. Or maybe there is a global switch to flip DRM_RENDER_ALLOW for the whole list ... cheers, Gerd