From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.6 v2] configure: don't silently disable systemd support Date: Thu, 10 Sep 2015 16:16:28 +0100 Message-ID: <1441898188.24450.386.camel@citrix.com> References: <1441883883-20724-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Za3aT-0004sb-1J for xen-devel@lists.xenproject.org; Thu, 10 Sep 2015 15:16:33 +0000 In-Reply-To: <1441883883-20724-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org On Thu, 2015-09-10 at 12:18 +0100, Wei Liu wrote: > Originally when user runs ./configure --enable-systemd and systemd > development library is not available the build system silently disables > systemd support. This is not in line with normal expectation. > > Instead, configure should error out when user has asked for systemd > support but development libraries can't be found. > > Reported-by: George Dunlap > Signed-off-by: Wei Liu Acked + applied to staging + staging-4.6 > --- > v2: invert the test to check for explicit "yes" value. > > Please rerun ./autogen.sh. > --- > m4/systemd.m4 | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/m4/systemd.m4 b/m4/systemd.m4 > index 8284993..e4b1aa5 100644 > --- a/m4/systemd.m4 > +++ b/m4/systemd.m4 > @@ -85,7 +85,11 @@ AC_DEFUN([AX_CHECK_SYSTEMD], [ > AC_DEFINE([HAVE_SYSTEMD], [1], [Systemd available and > enabled]) > systemd=y > AX_CHECK_SYSTEMD_LIBS() > - ],[systemd=n]) > + ],[ > + AS_IF([test "x$enable_systemd" = "xyes"], > + [AC_MSG_ERROR([Unable to find systemd > development library])], > + [systemd=n]) > + ]) > ],[systemd=n]) > ]) >