From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.6 v3 2/3] xl/libxl: disallow saving a guest with vNUMA configured Date: Fri, 11 Sep 2015 14:21:17 +0100 Message-ID: <1441977677.3549.30.camel@citrix.com> References: <1441896651-24735-1-git-send-email-wei.liu2@citrix.com> <1441896651-24735-3-git-send-email-wei.liu2@citrix.com> <1441901457.24450.392.camel@citrix.com> <20150910161515.GG1695@zion.uk.xensource.com> <1441904015.3549.5.camel@citrix.com> <20150910170526.GH1695@zion.uk.xensource.com> <1441968648.3549.19.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZaOGX-0003no-Ef for xen-devel@lists.xenproject.org; Fri, 11 Sep 2015 13:21:21 +0000 In-Reply-To: <1441968648.3549.19.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel , Ian Jackson , andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-09-11 at 11:50 +0100, Ian Campbell wrote: > But "is d->vnuma" corresponds to there being vnuma config for the domain. We discussed this IRL and concluded that we should stop trying to differentiate "no vnuma configuration" from "has empty vnuma configuration". So this code should raise this error if xc_domain_getvnuma returns anything other than rc == -1 && errno == XEN_EOPNOTSUPP. So the check is if ( rc != -1 || errno != XEN_EOPNOTSUPP ) I think. This then avoids any confusion about what it means to have a d->vnuma with nr_something == 0 in it. Ian.