From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: xl: libxl_domain_info: getting domain info list:
	Bad address
Date: Fri, 11 Sep 2015 17:01:04 +0100
Message-ID: <1441987264.3549.97.camel@citrix.com>
References: <55F1B8D2.9040708@citrix.com>
	<1441961548.3549.13.camel@citrix.com>	<55F29E51.5060506@citrix.com>
	<1441964293.3549.18.camel@citrix.com>
	<22002.62587.123417.80222@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <22002.62587.123417.80222@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Julien Grall <julien.grall@citrix.com>, Riku Voipio <riku.voipio@linaro.org>, Wei Liu <wei.liu2@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-09-11 at 16:34 +0100, Ian Jackson wrote:
> From 29e08dfa3a5c5a5aeb51fd01c67345e20cbb33c5 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@eu.citrix.com>
> Date: Fri, 11 Sep 2015 16:27:08 +0100
> Subject: [OSSTEST PATCH] cs-bisection-step: Cope with graph-out (testids)
>  containing ( ) etc.
> 
> cr-try-bisect launders / in the testid but relies on other characters
> being handled appropriately by cs-bisection-step.  So for example it
> can pass
> 
>   graph-out=/home/logs/results/bisect/linux-linus/test-armhf-armhf-xl
> -arndale.leak-check--basis(8)
> 
> But cs-bisection step foolishly assumed that the --graph-out argument
> did not contain any shell metacharacters.  Fix this.
> 
> Specifically:
> 
>  * Change invocations of perl's open to use the 3-argument form
>  * Change invocations of system to pass individual arguments rather
>    than constructing a shell script fragment and relying on the shell
>    to split it up.
>  * In particular, in the png processing pipeline, use the "sh -ec
>    <script> x <arg>..."  technique to pass the input and output
>    filenames in a way that does not expose them to the shell's parser.
>    To avoid making this code more tangled than it already is, also
>    break out the construction of what is now $scriptlet.
>  * Escape metacharacters in the URIs we put in the html output.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>