From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c Date: Fri, 11 Sep 2015 18:54:01 +0000 Message-ID: <1441997640.7836.1.camel@Odin.com> References: <20150908172356.GA1584@redhat.com> <20150909160418.GB28608@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150909160418.GB28608@lst.de> Content-Language: en-US Content-ID: <4A0CFA1049FE10469B9DFB86E33EE6DF@sw.swsoft.com> Sender: linux-next-owner@vger.kernel.org To: "hch@lst.de" Cc: "sfr@canb.auug.org.au" , "jim.epost@gmail.com" , "linux-kernel@vger.kernel.org" , "agk@redhat.com" , "linux-next@vger.kernel.org" , "snitzer@redhat.com" , "dm-devel@redhat.com" List-Id: dm-devel.ids T24gV2VkLCAyMDE1LTA5LTA5IGF0IDE4OjA0ICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToNCj4gRG9lcyB0aGlzIGZpeCB0aGUgaXNzdWUgZm9yIHlvdT8gIE15IEtjb25maWctZnUgaXNu J3QgdGhlIGJlc3QsDQo+IGJ1dCB0aGUgaWRlYSBiZWhpbmQgdGhpcyBpcyB0aGF0IGRtLW1wYXRo IHdpbGwgZGVwZW5kIG9uIFNDU0kNCj4gaWYgU0NTSV9ESCBpcyBzZXQuICBJZiBTQ1NJX0RIIGlz IG5vdCBzZXQgaXQgd2lsbCB1c2UgdGhlIHN0dWJzDQo+IGFuZCBub3QgY2FyZSBhYm91dCBTQ1NJ Lg0KDQpJIGFzc3VtZSBJJ20gT0sgdG8gYWRkDQoNClNpZ25lZC1vZmYtYnk6IENocmlzdG9waCBI ZWxsd2lnIDxoY2hAbHN0LmRlPg0KDQooSSdsbCBhc3N1bWUgc28gaWYgeW91IGRvbid0IHJlcGx5 KQ0KDQpKYW1lcw0KDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21kL0tjb25maWcgYi9kcml2ZXJz L21kL0tjb25maWcNCj4gaW5kZXggYjU5NzI3My4uZTllYTY4MSAxMDA2NDQNCj4gLS0tIGEvZHJp dmVycy9tZC9LY29uZmlnDQo+ICsrKyBiL2RyaXZlcnMvbWQvS2NvbmZpZw0KPiBAQCAtMzkzLDcg KzM5Myw3IEBAIGNvbmZpZyBETV9NVUxUSVBBVEgNCj4gIAkjIG9mIFNDU0lfREggaWYgdGhlIGxh dHRlciBpc24ndCBkZWZpbmVkIGJ1dCBpZg0KPiAgCSMgaXQgaXMsIERNX01VTFRJUEFUSCBtdXN0 IGRlcGVuZCBvbiBpdC4gIFdlIGdldCBhIGJ1aWxkDQo+ICAJIyBlcnJvciBpZiBTQ1NJX0RIPW0g YW5kIERNX01VTFRJUEFUSD15DQo+IC0JZGVwZW5kcyBvbiBTQ1NJX0RIIHx8ICFTQ1NJX0RIDQo+ ICsJZGVwZW5kcyBvbiAhU0NTSV9ESCB8fCBTQ1NJDQo+ICAJLS0taGVscC0tLQ0KPiAgCSAgQWxs b3cgdm9sdW1lIG1hbmFnZXJzIHRvIHN1cHBvcnQgbXVsdGlwYXRoIGhhcmR3YXJlLg0KPiAgDQoN Cg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753670AbbIKSyQ (ORCPT ); Fri, 11 Sep 2015 14:54:16 -0400 Received: from mx2.parallels.com ([199.115.105.18]:39352 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbbIKSyO (ORCPT ); Fri, 11 Sep 2015 14:54:14 -0400 From: James Bottomley To: "hch@lst.de" CC: "sfr@canb.auug.org.au" , "jim.epost@gmail.com" , "linux-kernel@vger.kernel.org" , "agk@redhat.com" , "linux-next@vger.kernel.org" , "snitzer@redhat.com" , "dm-devel@redhat.com" Subject: Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c Thread-Topic: randconfig build error with next-20150908, in drivers/md/dm-mpath.c Thread-Index: AQHQ7MM4vrAisOPLYkmsdh09Cgs2JQ== Date: Fri, 11 Sep 2015 18:54:01 +0000 Message-ID: <1441997640.7836.1.camel@Odin.com> References: <20150908172356.GA1584@redhat.com> <20150909160418.GB28608@lst.de> In-Reply-To: <20150909160418.GB28608@lst.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.12.11 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [151.124.179.37] Content-Type: text/plain; charset="utf-8" Content-ID: <4A0CFA1049FE10469B9DFB86E33EE6DF@sw.swsoft.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8BIsLGh008574 On Wed, 2015-09-09 at 18:04 +0200, Christoph Hellwig wrote: > Does this fix the issue for you? My Kconfig-fu isn't the best, > but the idea behind this is that dm-mpath will depend on SCSI > if SCSI_DH is set. If SCSI_DH is not set it will use the stubs > and not care about SCSI. I assume I'm OK to add Signed-off-by: Christoph Hellwig (I'll assume so if you don't reply) James > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > index b597273..e9ea681 100644 > --- a/drivers/md/Kconfig > +++ b/drivers/md/Kconfig > @@ -393,7 +393,7 @@ config DM_MULTIPATH > # of SCSI_DH if the latter isn't defined but if > # it is, DM_MULTIPATH must depend on it. We get a build > # error if SCSI_DH=m and DM_MULTIPATH=y > - depends on SCSI_DH || !SCSI_DH > + depends on !SCSI_DH || SCSI > ---help--- > Allow volume managers to support multipath hardware. > {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I