From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbbILG1i (ORCPT ); Sat, 12 Sep 2015 02:27:38 -0400 Received: from smtprelay0081.hostedemail.com ([216.40.44.81]:38830 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750768AbbILG1h (ORCPT ); Sat, 12 Sep 2015 02:27:37 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3868:3870:4321:5007:6261:10004:10400:10848:11026:11232:11657:11658:11914:12043:12296:12517:12519:12555:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bone66_252f33b3a6d0a X-Filterd-Recvd-Size: 1571 Message-ID: <1442039254.2769.2.camel@perches.com> Subject: Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons From: Joe Perches To: Shraddha Barke Cc: Greg Kroah-Hartman , Jes Sorensen , Julia Lawall , linux-kernel@vger.kernel.org Date: Fri, 11 Sep 2015 23:27:34 -0700 In-Reply-To: <1442037000-2953-1-git-send-email-shraddha.6596@gmail.com> References: <1442037000-2953-1-git-send-email-shraddha.6596@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-09-12 at 11:19 +0530, Shraddha Barke wrote: > This patch removes comparisons to true/false values on bool variables. > Fixed using Coccinelle Please do the "== false" and "!= false" cases at the same time or in another patch. > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c [] > @@ -409,7 +409,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l > > arg |= BIT(7);/* support entry 2~31 */ > > - if (shortGIrate == true) > + if (shortGIrate) > arg |= BIT(5); > > tx_ra_bitmap |= ((raid<<28)&0xf0000000);