From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?unknown-8bit?q?J=CE=B5an?= Sacren Date: Mon, 14 Sep 2015 00:27:43 -0600 Subject: [Intel-wired-lan] [next-queue 1/8] e1000: clean up the useless 'continue' statement In-Reply-To: <1442212070-24937-1-git-send-email-sakiwit@gmail.com> References: <1442212070-24937-1-git-send-email-sakiwit@gmail.com> Message-ID: <1442212070-24937-2-git-send-email-sakiwit@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: From: Jean Sacren We can delete the 'continue' statement as it is in the end of the block and doesn't do any good. To make it distinctive, put an empty line above the checking block. Additionally add a pair of braces in the 'else' branch. Signed-off-by: Jean Sacren --- drivers/net/ethernet/intel/e1000/e1000_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c index 74dc15055971..47397d7b97df 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_main.c +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c @@ -1199,12 +1199,13 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent) for (i = 0; i < 32; i++) { hw->phy_addr = i; e1000_read_phy_reg(hw, PHY_ID2, &tmp); + if (tmp == 0 || tmp == 0xFF) { if (i == 31) goto err_eeprom; - continue; - } else + } else { break; + } } }