From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] crypto: prevent helper ciphers from being allocated by users
Date: Tue, 17 Mar 2015 12:40:12 +0100 [thread overview]
Message-ID: <1442292.caf3IdtESe@tauon> (raw)
In-Reply-To: <20150317112350.GA11671@gondor.apana.org.au>
Am Dienstag, 17. März 2015, 22:23:50 schrieb Herbert Xu:
Hi Herbert,
>On Fri, Mar 13, 2015 at 10:09:21PM +0100, Stephan Mueller wrote:
>> +struct crypto_tfm *__crypto_alloc_tfm_safe(struct crypto_alg *alg,
>> u32 type, + u32 mask)
>> +{
>> + /*
>> + * Prevent all ciphers from being loaded which have a
cra_priority
>> + * of 0. Those cipher implementations are helper ciphers and
>> + * are not intended for general consumption.
>> + *
>> + * The only exceptions are the compression algorithms which
>> + * have no priority.
>> + */
>> + if (!alg->cra_priority &&
>> + ((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) !=
>> + CRYPTO_ALG_TYPE_PCOMPRESS) &&
>> + ((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) !=
>> + CRYPTO_ALG_TYPE_COMPRESS))
>> + return ERR_PTR(-ENOENT);
>
>How about adding a flag to all these internal algorithms and then
>change crypto_alg_mod_lookup to disable that flag by default?
The issue with flags is the following: first we have to think about
whether we want a black list or white list approach. Your suggestion
implies a black list. Black lists for ensuring security is not good IMHO
as it has a tendency to miss cases. This especially applies to this area
where we have already an indicator for internal ciphers: the prio is so
low that it will never ever be selected based on the name. Now, adding a
flag means that we mark such an internal cipher twice.
Therefore, I would not opt for such a flag (at least for a black list)
and stay with the prio approach.
Ciao
Stephan
next prev parent reply other threads:[~2015-03-17 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 21:09 [RFC PATCH] crypto: prevent helper ciphers from being allocated by users Stephan Mueller
2015-03-15 11:49 ` Stephan Mueller
2015-03-17 11:23 ` Herbert Xu
2015-03-17 11:40 ` Stephan Mueller [this message]
2015-03-17 11:45 ` Herbert Xu
2015-03-17 14:59 ` Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442292.caf3IdtESe@tauon \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.