From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523 Date: Tue, 15 Sep 2015 09:40:34 +0100 Message-ID: <1442306434.3549.321.camel@citrix.com> References: <1442243163-2675-1-git-send-email-will.deacon@arm.com> <1442244988.3549.313.camel@citrix.com> <20150914155854.GF23878@arm.com> <55F7535A.3020905@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZblnK-0008AO-0J for xen-devel@lists.xenproject.org; Tue, 15 Sep 2015 08:40:54 +0000 In-Reply-To: <55F7535A.3020905@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Marc Zyngier , "xen-devel@lists.xenproject.org" , Will Deacon List-Id: xen-devel@lists.xenproject.org On Tue, 2015-09-15 at 00:08 +0100, Julien Grall wrote: > On 14/09/2015 16:58, Will Deacon wrote: > > > The Xen ctxt switch code[0] has DACR_EL2 in the midst of it all, and > > > certainly followed by some sysregs, which I've got my fingers crossed > > > happens to be sufficient (other than maybe adding a comment). > > > > It looks like you restore CONTEXTIDR_EL1 fairly late, so you should be > > ok. Thanks Will. > It may be worth to have a comment in the code explaining the errata to > avoid introduce by inadvertence if we plan to re-order the context > switch. > > I can send a patch for that. Yes, please, a comment right before we restore DACR32_EL2 with the list of register Will gave would be best I think. > > Regards, >