From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 1/2] xen/arm: gic-v3: Clean-up the GIC*_PIDR2_* definitions
Date: Tue, 15 Sep 2015 10:35:33 +0100 [thread overview]
Message-ID: <1442309733.3549.354.camel@citrix.com> (raw)
In-Reply-To: <1442244744-30190-2-git-send-email-julien.grall@citrix.com>
On Mon, 2015-09-14 at 16:32 +0100, Julien Grall wrote:
> GICR_PIDR2 and GICD_PIDR2 use the same register layout. Rather than
> define twice, one of which is an alias to the other, introduce
> GIC_PIDR2_*
> defines.
>
> Also:
> * Use the same prefix for the mask and the value
> * Integrate the shift in the value to avoid shifting in the code
> * Use GICv* to match the value name in the spec
> * Move them in a proper place
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-09-15 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 15:32 [PATCH 0/2] GICv3: Clean up + enable support on GICv4 Julien Grall
2015-09-14 15:32 ` [PATCH 1/2] xen/arm: gic-v3: Clean-up the GIC*_PIDR2_* definitions Julien Grall
2015-09-15 9:35 ` Ian Campbell [this message]
2015-09-14 15:32 ` [PATCH 2/2] xen/arm: gic-v3: Allow Xen to run on hardware reporting GICv4 Julien Grall
2015-09-15 9:49 ` Ian Campbell
2015-09-15 10:28 ` Andre Przywara
2015-09-15 11:02 ` Julien Grall
2015-09-15 11:15 ` Ian Campbell
2015-09-15 11:19 ` Julien Grall
2015-09-24 11:32 ` Ian Campbell
2015-09-21 15:54 ` [PATCH 0/2] GICv3: Clean up + enable support on GICv4 Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442309733.3549.354.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.