From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxl: slightly refine pci-assignable-{add,
 remove} handling
Date: Tue, 15 Sep 2015 12:16:02 +0100
Message-ID: <1442315762.3549.376.camel@citrix.com>
References: <55F1958602000078000A1AEE@prv-mh.provo.novell.com>
	<CAFLBxZYYHVUazguzNonScvVEAKVqX+AxPgMNTLRBEe==2R7AKw@mail.gmail.com>
	<1442309496.3549.351.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6930d5c4d=Ian.Campbell@citrix.com>)
	id 1ZboDn-0001rQ-3Z
	for xen-devel@lists.xenproject.org; Tue, 15 Sep 2015 11:16:23 +0000
In-Reply-To: <1442309496.3549.351.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-09-15 at 10:31 +0100, Ian Campbell wrote:
> On Mon, 2015-09-14 at 10:50 +0100, George Dunlap wrote:
> > On Thu, Sep 10, 2015 at 1:36 PM, Jan Beulich <JBeulich@suse.com> wrote:
> > > While it appears to be intentional for "xl pci-assignable-remove" to
> > > not re-bind the original driver by default (requires the -r option),
> > > permanently losing the information which driver was originally used
> > > seems bad. Make "add; remove; add; remove -r" re-bind the original
> > > driver by allowing "remove" to delete the information only upon
> > > successful re-bind.
> > 
> > I would be open to the argument that I was being overly paranoid in
> > making "xl pci-assignable-remove" not re-bind by default.  But either
> > way:
> > 
> > Reviewed-by: George Dunlap <george.dunlap@citrix.com>
> 
> The use of "rc" to hold a non-libxl error code (0 or -1 in this case) in
> _add is not allowed by libxl coding style, but is consistent with the
> same
> thing existing in _remove, also this code is mostly in hypervisor coding
> style so it seems tolerable for this new code to be so too.
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

and applied.