From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] arm: reduce power use by contented spin
 locks with WFE/SEV
Date: Tue, 15 Sep 2015 12:17:02 +0100
Message-ID: <1442315822.3549.379.camel@citrix.com>
References: <1438601359-2576-1-git-send-email-ian.campbell@citrix.com>
	<1442312907.3549.368.camel@citrix.com>
	<alpine.DEB.2.02.1509151139240.2672@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1509151139240.2672@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com, xen-devel@lists.xen.org, julien.grall@citrix.com, David Vrabel <david.vrabel@citrix.com>, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-09-15 at 11:39 +0100, Stefano Stabellini wrote:
> On Tue, 15 Sep 2015, Ian Campbell wrote:
> > On Mon, 2015-08-03 at 12:29 +0100, Ian Campbell wrote:
> > > From: David Vrabel <david.vrabel@citrix.com>
> > > 
> > > Instead of cpu_relax() while spinning and observing the ticket head,
> > > introduce arch_lock_relax() which executes a WFE instruction.  After
> > > the ticket head is changed call arch_lock_signal() to execute an SEV
> > > instruction (with the required DSB first) to wake any spinners.
> > > 
> > > This should improve power consumption when locks are contented and
> > > spinning.
> > > 
> > > For consistency also move arch_lock_(acquire|release)_barrier to
> > > asm/spinlock.h.
> > > 
> > > Booted the result on arm32 (Midway) and arm64 (Mustang). Build test
> > > only on amd64.
> > > 
> > > Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> > > [ijc: add barrier, rename as arch_lock_*, move arch_lock_*_barrier,
> > > test]
> > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > > Cc: Jan Beulich <jbeulich@suse.com>
> > > Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> > 
> > Andy has Reviewed-by but this change still lacks an Ack from the ARM
> > side.
> > Stefano, was your previous "The code should work though." intended as
> > an
> > Ack?
> 
> Yes

Applied then. thanks.

Ian.