From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbbIOU12 (ORCPT ); Tue, 15 Sep 2015 16:27:28 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36644 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbbIOU11 (ORCPT ); Tue, 15 Sep 2015 16:27:27 -0400 From: Eric Curtin To: valentina.manea.m@gmail.com, shuah.kh@samsung.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: tools: usbip: detach: avoid calling strlen() at each iteration Date: Tue, 15 Sep 2015 21:27:20 +0100 Message-Id: <1442348840-32025-1-git-send-email-ericcurtin17@gmail.com> X-Mailer: git-send-email 2.4.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of calling strlen on every iteration of the for loop, just call it once and cache the result in a temporary local variable which will be used in the for loop instead. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index 05c6d15..9db9d21 100644 --- a/tools/usb/usbip/src/usbip_detach.c +++ b/tools/usb/usbip/src/usbip_detach.c @@ -47,7 +47,9 @@ static int detach_port(char *port) uint8_t portnum; char path[PATH_MAX+1]; - for (unsigned int i = 0; i < strlen(port); i++) + unsigned int port_len = strlen(port); + + for (unsigned int i = 0; i < port_len; i++) if (!isdigit(port[i])) { err("invalid port %s", port); return -1;