From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 02/27] Executive: cs-job-create:
 Check that OSSTEST_FLIGHT is not set
Date: Wed, 16 Sep 2015 14:48:05 +0100
Message-ID: <1442411285.18856.67.camel@citrix.com>
References: <1442410530-9665-1-git-send-email-ian.jackson@eu.citrix.com>
	<1442410530-9665-3-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6948b2dab=Ian.Campbell@citrix.com>)
	id 1ZcD4D-0006QO-Qr
	for xen-devel@lists.xenproject.org; Wed, 16 Sep 2015 13:48:09 +0000
In-Reply-To: <1442410530-9665-3-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-09-16 at 14:35 +0100, Ian Jackson wrote:
> If OSSTEST_FLIGHT is set on entry to JobDB::Executive::flight_create,
> fail.  This obviously represents some kind of mistake.
> 
> One effect is that standalone-generate-dump-flight-runvars won't fill
> an Executive database with test flights.

Speaking from experience there?


> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>  Osstest/JobDB/Executive.pm |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm
> index cc52f57..6ba3d37 100644
> --- a/Osstest/JobDB/Executive.pm
> +++ b/Osstest/JobDB/Executive.pm
> @@ -89,6 +89,8 @@ END
>  
>  sub flight_create ($$$) { #method
>      my ($jd,$intended,$branch) = @_;
> +    die "OSSTEST_FLIGHT set on entry to
> JobDB::Executive::flight_create\n"
> +	if $ENV{'OSSTEST_FLIGHT'};
>      $dbh_tests->do(<<END, {}, $branch, $intended);
>               INSERT INTO flights
>                           (flight,  started, blessing,       branch,
> intended)