From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v2 3/4] Add support for selecting
 resources based on their properties.
Date: Wed, 16 Sep 2015 14:58:58 +0100
Message-ID: <1442411938.18856.79.camel@citrix.com>
References: <1442404047.18856.51.camel@citrix.com>
	<1442404064-16192-3-git-send-email-ian.campbell@citrix.com>
	<22009.29631.949655.327160@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <22009.29631.949655.327160@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-09-16 at 14:50 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 3/4] Add support for selecting
> resources based on their properties."):
> > In particular for allocating hosts based on host properties.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> 
> > +    die "propname: $prop?" unless propname_check($prop);
> ...
> > +sub propname_check ($) {
> > +    # ensure propname is valid and in the canonical WordWordWord form
> > +    # (rather than, say, one of the legacy forms described in
> > +    # propname_massage).
> 
> As a matter of taste, I would have had propname_check throw rather
> than making it be a predicate.

I did wonder about that. I'm happy to change if you want me to.

Ian.