From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 13/27] cr-ensure-disk-space: Look at referring flights Date: Wed, 16 Sep 2015 15:09:22 +0100 Message-ID: <1442412562.18856.83.camel@citrix.com> References: <1442410530-9665-1-git-send-email-ian.jackson@eu.citrix.com> <1442410530-9665-14-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZcDOo-0003LF-Hr for xen-devel@lists.xenproject.org; Wed, 16 Sep 2015 14:09:26 +0000 In-Reply-To: <1442410530-9665-14-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-09-16 at 14:35 +0100, Ian Jackson wrote: > Previously the flight to delete was simply the one with the lowest > flight number. Now we sort flights not by their own flight number, > but by the highest flight number of any referencing flight. > > This means that flights whose builds are being reused are kept as long > as the reusing flights. > > This almost-entirely fixes a largely-theoretical race in the way > cs-bisection-step works (where the flight's logs and build outputs > might be deleted between the setup and execution of the referring > flight). > > A smaller race still exists because the stash check in > cs-bisection-step occurs before the being-created flight is visible to > other db clients. We will have to fix this by taking the flights > lock. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell