From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 17/27] mg-show-flight-runvars: Decorate synth runvar names with ~ Date: Wed, 16 Sep 2015 15:19:44 +0100 Message-ID: <1442413184.18856.88.camel@citrix.com> References: <1442410530-9665-1-git-send-email-ian.jackson@eu.citrix.com> <1442410530-9665-18-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZcDYr-0005CL-UQ for xen-devel@lists.xenproject.org; Wed, 16 Sep 2015 14:19:50 +0000 In-Reply-To: <1442410530-9665-18-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-09-16 at 14:35 +0100, Ian Jackson wrote: > Make mg-show-flight-runvars -a append ~ to the names of synth runvars. > (This is consistent with the new syntax in cs-job-create.) > > We do this by editing $row->[1] (and $colws[1]) so we can avoid > disturbing the general column format calcuation and printing; this "calculation" > means we have to copy $row (because the value in the DB $row is > readonly). fetchrow_array instead of fetchrow_arrayref would avoid the copy, at the expense of removing -> from the usages (or taking the ref yourself). > We have to check for $synth eq 'f' as well as $synth being boolean > false, because SQLite's typeless nature (or, to put it another way, > DBD::SQLite's failure to look at the schema) means that a boolean > field's value of 'f' or 't' is simply returned as a string to Perl. > But of course "f" is trueish in Perl. > > Signed-off-by: Ian Jackson Nonetheless: Acked-by: Ian Campbell < ian.campbell@citrix.com >