All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST] Switch to merged qemu-xen{, -traditional}.git trees
Date: Thu, 17 Sep 2015 11:47:22 +0100	[thread overview]
Message-ID: <1442486842.18856.170.camel@citrix.com> (raw)
In-Reply-To: <1442486620.18856.168.camel@citrix.com>

On Thu, 2015-09-17 at 11:43 +0100, Ian Campbell wrote:
> > > +qemu-upstream-*-testing)
> > ...
> > > +	# For now also push to the old split trees for historical
> > > +	# branches only (qemu-upstream started with xen-4.2-testing
> > > +	# and the split trees end at xen-4.6-testing)
> > > +	case "$xenbranch" in
> > > +	    xen-4.[23456]-testing)
> > > +		tree=$XENBITS:/home/xen/git/qemu-upstream
> > > -${xenbranch#xen-}.git
> > > +		git push $tree $revision:refs/heads/master
> > 
> > I think this would be clearer if not done in terms of xenbranch.  I
> > would use case $branch and then $branchcore.  What do you think ?
> 
> Good idea.

$branch is a bit wordy at this point, but $branchcore is usable for both
cases incrementally:

diff --git a/ap-push b/ap-push
index c3bc814..41acb39 100755
--- a/ap-push
+++ b/ap-push
@@ -77,9 +77,9 @@ qemu-upstream-*-testing)
        # For now also push to the old split trees for historical
        # branches only (qemu-upstream started with xen-4.2-testing
        # and the split trees end at xen-4.6-testing)
-       case "$xenbranch" in
-           xen-4.[23456]-testing)
-               tree=$XENBITS:/home/xen/git/qemu-upstream-${xenbranch#xen-}.git
+       case "$branchcore" in
+           4.[23456])
+               tree=$XENBITS:/home/xen/git/qemu-upstream-${branchcore}-testing.git
                git push $tree $revision:refs/heads/master
                ;;
        esac

Look ok?

  reply	other threads:[~2015-09-17 10:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  9:37 [PATCH OSSTEST+XEN 0/1+1] Switching to one qemu tree per qemu version (trad vs upstream) Ian Campbell
2015-09-17  9:37 ` [PATCH OSSTEST] Switch to merged qemu-xen{, -traditional}.git trees Ian Campbell
2015-09-17 10:31   ` Ian Jackson
2015-09-17 10:43     ` Ian Campbell
2015-09-17 10:47       ` Ian Campbell [this message]
2015-10-02 13:43         ` Ian Jackson
2015-10-02 13:53           ` Ian Campbell
2015-10-05 16:39             ` Ian Jackson
2015-10-19 11:44             ` Ian Jackson
2015-10-20 10:34               ` Ian Campbell
2015-10-21 10:16                 ` Ian Campbell
2015-10-21 10:35                   ` Ian Jackson
2015-10-21 10:50                     ` Ian Campbell
2015-10-21 11:07                 ` Ian Campbell
2015-10-21 13:15                 ` Ian Campbell
2015-10-21 13:25                   ` Ian Campbell
2015-10-21 14:12                   ` Ian Campbell
2015-10-21 14:23                     ` Ian Campbell
2015-10-29 15:24                   ` Ian Jackson
2015-09-17  9:37 ` [PATCH XEN] Config: Switch to unified qemu trees Ian Campbell
2015-09-17 10:32   ` Ian Jackson
2015-09-17 10:41     ` Ian Campbell
2015-10-16 11:34       ` Ian Jackson
2015-10-21 13:18         ` Ian Campbell
2015-09-17 10:23 ` [PATCH OSSTEST+XEN 0/1+1] Switching to one qemu tree per qemu version (trad vs upstream) Ian Jackson
2015-09-17 10:36   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442486842.18856.170.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.