Re: [PATCH v2] Rename 'BRANCH' variable to 'SRCBRANCH' for clearness

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2015-09-17 at 10:33 -0300, Otavio Salvador wrote:
> On Thu, Sep 17, 2015 at 10:30 AM, Gary Thomas <gary@mlbassoc.com> wrote:
> > On 2015-09-17 07:21, Otavio Salvador wrote:
> >>
> >> The 'BRANCH' variable name has no explicit relation with the
> >> SRC_URI. Using 'SRCBRANCH' makes it more obvious and easier to
> >> identify.
> >>
> >> This patch makes the use consistent across the metadata.
> >>
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >
> >
> > These should be separated into one for glibc and another for mmc.
> > Also, the subject line needs to mention the recipe name based on
> > the commit guidelines.
> 
> I can split it but it does not make much sense for this specific case,
> IMO. This is a global change and so it provides an easier view of
> affected recipes for such a change. If it, supposedly, introduces a
> regression it is easier to revert it.

I don't think it needs to be split, I would like "glibc/mmc-utils:" at
the start of the subject line so we give the casual reader some idea
what the scope of the patch is though. In this case I'll just add that
before merging.

Cheers,

Richard