From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: xen/arm: gicv3: Computation of GICD_TYPER.IDbits
Date: Fri, 18 Sep 2015 09:33:50 +0100
Message-ID: <1442565230.18856.240.camel@citrix.com>
References: <CALicx6s4Nej2ejduV1j3Xt_Rcgng50jo-19UBpe4QwikJyktYw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6s4Nej2ejduV1j3Xt_Rcgng50jo-19UBpe4QwikJyktYw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>, Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-09-18 at 12:56 +0530, Vijay Kilari wrote:
> Hi Julien,
> 
>  static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info)
>  {
>      ...
>            case GICD_TYPER:
>            {
>                /*
>                 * Number of interrupt identifier bits supported by the
> GIC
>                 * Stream Protocol Interface
>                 */
>                unsigned int irq_bits =
> get_count_order(vgic_num_irqs(v->domain));
> }
> 
> I think we should use ilog2() instead of get_count_order()?

Please explain why.

Ian.