From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 18/33] mg-show-flight-runvars: Decorate synth runvar names with ~ Date: Fri, 18 Sep 2015 10:27:43 +0100 Message-ID: <1442568463.18856.275.camel@citrix.com> References: <1442511480-32587-1-git-send-email-ian.jackson@eu.citrix.com> <1442511480-32587-19-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZcrxZ-0006OW-HQ for xen-devel@lists.xenproject.org; Fri, 18 Sep 2015 09:28:01 +0000 In-Reply-To: <1442511480-32587-19-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-09-17 at 18:37 +0100, Ian Jackson wrote: > Make mg-show-flight-runvars -a append ~ to the names of synth runvars. > (This is consistent with the new syntax in cs-job-create.) > > We do this by editing $row[1] (and $colws[1]) so we can avoid > disturbing the general column format calculation and printing. > > We switch to fetchrow_array rather than fetchrow_arrayref. This is > clearer and also avoids having to copy $row (because the value in the > DB $row from fetchrow_hashref would be readonly). > > We have to check for $synth eq 'f' as well as $synth being boolean > false, because SQLite's typeless nature (or, to put it another way, > DBD::SQLite's failure to look at the schema) means that a boolean > field's value of 'f' or 't' is simply returned as a string to Perl. > But of course "f" is trueish in Perl. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell