Re: [OSSTEST PATCH 30/33] cr-daily-branch: Use mg-adjust-flight to have smoke tests reuse builds

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2015-09-17 at 18:37 +0100, Ian Jackson wrote:
> The smoke tests are for testing xen-unstable.  We want to avoid
> building anything else.  So arrange to reuse previous builds by
> calling mg-adjust-flight-makexrefs.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
> v2: New patch
> ---
>  cr-daily-branch |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/cr-daily-branch b/cr-daily-branch
> index 9500bdc..6a5124a 100755
> --- a/cr-daily-branch
> +++ b/cr-daily-branch
> @@ -276,7 +276,17 @@ if [ "x$NEW_REVISION" = "x$OLD_REVISION" ]; then
>  fi
>  
>  $DAILY_BRANCH_PREMAKE_HOOK
> +
>  flight=`$makeflight $branch $xenbranch $OSSTEST_BLESSING "$@"`
> +
> +case $branch in
> +xen-unstable-smoke)
> +	./mg-adjust-flight-makexrefs -v $flight \
> +		'!build-amd64 !build-armhf build-*' \
> +		--debug --branch=xen-unstable --blessings=real

$blessings_arg might be better than an open coded real?

Oh, I see, you want to only pickup real builds, even for adhoc or play
jobs. That makes sense. Maybe with say so either in a comment or the commit
message?

Otherwise:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> +	;;
> +esac
> +
>  $DAILY_BRANCH_POSTMAKE_HOOK
>  
>  heading=tmp/$flight.heading-info