From: Thomas Renninger <trenn@suse.de>
To: WANG Chao <chaowang@redhat.com>
Cc: kexec@lists.infradead.org, horms@verge.net.au, linn@hp.com,
hpa@zytor.com, dyoung@redhat.com, Vivek Goyal <vgoyal@redhat.com>,
ebiederm@xmission.com
Subject: Re: [PATCH v4 2/4] x86: Store memory ranges globally used for crash kernel to boot into
Date: Fri, 28 Mar 2014 16:44:33 +0100 [thread overview]
Message-ID: <1442762.HKg1LDRF5G@skinner> (raw)
In-Reply-To: <20140328052349.GD2944@dhcp-17-89.nay.redhat.com>
On Friday, March 28, 2014 01:23:49 PM WANG Chao wrote:
> On 03/27/14 at 06:32pm, Vivek Goyal wrote:
...
> I was just trying to keep the change as minimal as possible, so that the
> reviewers can be more clear of what the patch does instead of something
> looks messed up.
Sounds very sane. I tried it the other way around:
clean up and then do the functional change
and I ended up in a mess changing back and forth and I had to move on
to other stuff in the end.
> But if you have no problem review it, I can do some
> clean up within this patch. However I think it's better to be addressed
> the cleanup in the future, or at least as a separated patch in this
> series.
Seeing some cleanups, especially getting rid of the duplicate code to get
memory ranges in kdump and kexec case (which I expect still exists?) on top
later would be great.
Thomas
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-03-28 15:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 8:03 [PATCH v4 0/4] kexec-tools, x86: E820 memmap pass for kdump WANG Chao
2014-03-19 8:03 ` [PATCH v4 1/4] cleanup: add dbgprint_mem_range function WANG Chao
2014-03-20 3:49 ` Simon Horman
2014-03-19 8:03 ` [PATCH v4 2/4] x86: Store memory ranges globally used for crash kernel to boot into WANG Chao
2014-03-27 22:32 ` Vivek Goyal
2014-03-28 5:23 ` WANG Chao
2014-03-28 14:01 ` Vivek Goyal
2014-03-28 15:44 ` Thomas Renninger [this message]
2014-03-28 16:05 ` Vivek Goyal
2014-03-28 2:19 ` Dave Young
2014-03-28 5:36 ` WANG Chao
2014-03-28 3:24 ` Dave Young
2014-03-28 6:13 ` WANG Chao
2014-03-28 6:43 ` Dave Young
2014-03-28 6:51 ` Dave Young
2014-03-28 7:12 ` Dave Young
2014-04-01 7:04 ` WANG Chao
2014-04-01 8:41 ` Dave Young
2014-04-01 8:54 ` WANG Chao
2014-04-01 9:36 ` Dave Young
2014-04-01 9:52 ` WANG Chao
2014-03-19 8:04 ` [PATCH v4 3/4] x86: add --pass-memmap-cmdline option WANG Chao
2014-03-19 8:04 ` [PATCH v4 4/4] x86: Pass memory range via E820 for kdump WANG Chao
2014-03-27 22:50 ` Vivek Goyal
2014-03-28 4:52 ` WANG Chao
2014-03-28 13:53 ` Vivek Goyal
2014-03-28 3:28 ` Dave Young
2014-03-28 4:53 ` WANG Chao
2014-03-19 17:57 ` [PATCH v4 0/4] kexec-tools, x86: E820 memmap pass " Linn Crosetto
2014-03-20 3:50 ` Simon Horman
2014-03-20 5:00 ` WANG Chao
2014-03-20 15:42 ` Vivek Goyal
2014-03-27 10:31 ` WANG Chao
2014-03-27 22:23 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442762.HKg1LDRF5G@skinner \
--to=trenn@suse.de \
--cc=chaowang@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linn@hp.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.