From: Oliver Neukum <oneukum@suse.com>
To: Matthew Garrett <mjg59@coreos.com>
Cc: netdev@vger.kernel.org, Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH] usbnet: New driver for QinHeng CH9200 devices
Date: Mon, 21 Sep 2015 08:36:29 +0200 [thread overview]
Message-ID: <1442817389.1620.4.camel@suse.com> (raw)
In-Reply-To: <1442741138-8193-1-git-send-email-mjg59@coreos.com>
On Sun, 2015-09-20 at 02:25 -0700, Matthew Garrett wrote:
> There's a bunch of cheap USB 10/100 devices based on QinHeng chipsets.
> The
> vendor driver supports the CH9100 and CH9200 devices, but the majority
> of
> the code is of the if (ch9100) {} else {} form, with the most
> significant
> difference being that CH9200 provides a real MII interface but CH9100
> fakes
> one with a bunch of global variables and magic commands. I don't have
> a
> CH9100, so it's probably better if someone who does provides an
> independent
> driver for it. In any case, this is a lightly cleaned up version of
> the
> vendor driver with all the CH9100 code dropped.
Hi,
surprisingly nice for a vendor driver. It even covers endianness
correctly. I'd say that the remaining issues will be easy to fix
and that would be easier on a merged driver.
Regards
Oliver
next prev parent reply other threads:[~2015-09-21 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 9:25 [PATCH] usbnet: New driver for QinHeng CH9200 devices Matthew Garrett
2015-09-21 6:36 ` Oliver Neukum [this message]
2015-09-21 23:17 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-09-21 10:08 Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442817389.1620.4.camel@suse.com \
--to=oneukum@suse.com \
--cc=mjg59@coreos.com \
--cc=mjg59@srcf.ucam.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.