From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.6] xen/arm: vgic-v2: Map the GIC
 virtual CPU interface with the correct size
Date: Mon, 21 Sep 2015 13:56:34 +0100
Message-ID: <1442840194.10338.92.camel@citrix.com>
References: <1442512803-798-1-git-send-email-julien.grall@citrix.com>
	<1442566410.18856.252.camel@citrix.com>
	<1442836446.10338.59.camel@citrix.com> <55FFF7E9.7020103@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=699e7550d=Ian.Campbell@citrix.com>)
	id 1Ze0eA-0002QH-AQ
	for xen-devel@lists.xenproject.org; Mon, 21 Sep 2015 12:56:42 +0000
In-Reply-To: <55FFF7E9.7020103@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com, Wei.Liu2@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-09-21 at 13:28 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 21/09/15 12:54, Ian Campbell wrote:
> > On Fri, 2015-09-18 at 09:53 +0100, Ian Campbell wrote:
> > > On Thu, 2015-09-17 at 19:00 +0100, Julien Grall wrote:
> > > > On GICv2, the GIC virtual CPU interface is at minimum 8KB. Due some
> > > > to
> > > > some necessary quirk for GIC using 64KB stride, we are mapping the
> > > > region in 2 time.
> > > > The first mapping is 4KB and the second one is 8KB, i.e 12KB in
> > > > total.
> > > > Although the minimum supported size (and widely used) is 8KB. This
> > > > means
> > > > that we are mapping 4KB more to any guest using GICv2.
> > > > 
> > > > While this looks scary at first glance, the GIC virtual CPU
> > > > interface
> > > > is
> > > > most frequently at the end the GIC I/O region. So we will most
> > > > likely
> > > > map an an unused I/O region or a mirrored version of GICV for
> > > > platform
> > > > using 64KB stride.
> > > > 
> > > > Nonetheless, fix the second mapping to only map 4KB.
> > > > 
> > > > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > > 
> > > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > > 
> > > > ---
> > > > 
> > > > This is a candidate for Xen 4.6 and backport to Xen 4.5.
> > > 
> > > I concur and with Wei not being around I shall plan to apply later
> > > today
> > > unless there are objections.
> > 
> > I got distracted. Now applied to staging and staging-4.6 now and noted
> > for
> > later application to 4.5
> 
> It won't apply cleanly for Xen 4.5, this code was living in the gic
> driver. I will send a backport patch for it.

Thanks.