From: Punit Vara <punitvara@gmail.com>
To: gregkh@linuxfoundation.org
Cc: joe@perches.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Punit Vara <punitvara@gmail.com>
Subject: [PATCH] Staging: rts5208: Coding style warnings fix for block comments
Date: Mon, 21 Sep 2015 23:31:29 +0530 [thread overview]
Message-ID: <1442858489-12139-1-git-send-email-punitvara@gmail.com> (raw)
This patch is to rtsx_chip.h that fixes up following warning reported
by checkpatch.pl :
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/staging/rts5208/rtsx_chip.h | 66 +++++++++++++++++++++++--------------
1 file changed, 42 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.h b/drivers/staging/rts5208/rtsx_chip.h
index c295b1e..2a6424d 100644
--- a/drivers/staging/rts5208/rtsx_chip.h
+++ b/drivers/staging/rts5208/rtsx_chip.h
@@ -44,8 +44,10 @@
#define MG_SET_ICV_SLOW
/* HW may miss ERR/CMDNK signal when sampling INT status. */
#define MS_SAMPLE_INT_ERR
- /* HW DO NOT support Wait_INT function during READ_BYTES
- * transfer mode */
+ /*
+ * HW DO NOT support Wait_INT function during READ_BYTES
+ * transfer mode
+ */
#define READ_BYTES_WAIT_INT
#endif
@@ -102,17 +104,19 @@
#define TRANSPORT_ERROR 3 /* Transport bad (i.e. device dead) */
-/*-----------------------------------
- Start-Stop-Unit
------------------------------------*/
+/* -----------------------------------
+ * Start-Stop-Unit
+ * -----------------------------------
+ */
#define STOP_MEDIUM 0x00 /* access disable */
#define MAKE_MEDIUM_READY 0x01 /* access enable */
#define UNLOAD_MEDIUM 0x02 /* unload */
#define LOAD_MEDIUM 0x03 /* load */
-/*-----------------------------------
- STANDARD_INQUIRY
------------------------------------*/
+/* -----------------------------------
+ * STANDARD_INQUIRY
+ * -----------------------------------
+ */
#define QULIFIRE 0x00
#define AENC_FNC 0x00
#define TRML_IOP 0x00
@@ -130,16 +134,24 @@
/* Dynamic flag definitions: used in set_bit() etc. */
#define RTSX_FLIDX_TRANS_ACTIVE 18 /* 0x00040000 transfer is active */
-#define RTSX_FLIDX_ABORTING 20 /* 0x00100000 abort is in
- * progress */
-#define RTSX_FLIDX_DISCONNECTING 21 /* 0x00200000 disconnect
- * in progress */
+#define RTSX_FLIDX_ABORTING 20 /*
+ * 0x00100000 abort is in
+ * progress
+ */
+#define RTSX_FLIDX_DISCONNECTING 21 /*
+ * 0x00200000 disconnect
+ * in progress
+ */
#define ABORTING_OR_DISCONNECTING ((1UL << US_FLIDX_ABORTING) | \
(1UL << US_FLIDX_DISCONNECTING))
-#define RTSX_FLIDX_RESETTING 22 /* 0x00400000 device reset
- * in progress */
-#define RTSX_FLIDX_TIMED_OUT 23 /* 0x00800000 SCSI
- * midlayer timed out */
+#define RTSX_FLIDX_RESETTING 22 /*
+ * 0x00400000 device reset
+ * in progress
+ */
+#define RTSX_FLIDX_TIMED_OUT 23 /*
+ * 0x00800000 SCSI
+ * midlayer timed out
+ */
#define DRCT_ACCESS_DEV 0x00 /* Direct Access Device */
#define RMB_DISC 0x80 /* The Device is Removable */
@@ -174,9 +186,10 @@
#define FIRST_RESET 0x01
#define USED_EXIST 0x02
-/*-----------------------------------
- SENSE_DATA
------------------------------------*/
+/* -----------------------------------
+ * SENSE_DATA
+ * -----------------------------------
+ */
/*---- valid ----*/
#define SENSE_VALID 0x80 /* Sense data is valid as SCSI2 */
#define SENSE_INVALID 0x00 /* Sense data is invalid as SCSI2 */
@@ -712,9 +725,12 @@ struct rtsx_chip {
int cur_card;
unsigned long need_release; /* need release bit map */
- unsigned long need_reset; /* need reset
- * bit map */
- /* Flag to indicate that this card is just resumed from SS state,
+ unsigned long need_reset; /*
+ * need reset
+ * bit map
+ */
+ /*
+ * Flag to indicate that this card is just resumed from SS state,
* and need released before being resetted
*/
unsigned long need_reinit;
@@ -732,8 +748,10 @@ struct rtsx_chip {
u8 card_ejected; /* card ejected bit map */
u8 card_wp; /* card write protected bit map */
- u8 lun_mc; /* flag to indicate whether to answer
- * MediaChange */
+ u8 lun_mc; /*
+ * flag to indicate whether to answer
+ * MediaChange
+ */
#ifndef LED_AUTO_BLINK
int led_toggle_counter;
--
2.5.2
next reply other threads:[~2015-09-21 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 18:01 Punit Vara [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-21 19:00 [PATCH] Staging: rts5208: Coding style warnings fix for block comments Punit Vara
2015-09-21 16:29 Punit Vara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442858489-12139-1-git-send-email-punitvara@gmail.com \
--to=punitvara@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.